Print unhandled errors in REPL mode #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -560,19 +560,12 @@ main (int argc, | |||
| jerry_api_value_t ret_val; | |||
| ret_code = jerry_api_eval (buffer, len, false, false, &ret_val); | |||
|
|
|||
| if (ret_code == JERRY_COMPLETION_CODE_OK) | |||
| // print return value | |||
There was a problem hiding this comment.
I thins comment should be fixed.
dbatyai
force-pushed
the
print_errors_in_repl
branch
from
493cd75 to
6eaeb9a
Compare
| @@ -527,17 +527,14 @@ jerry_api_convert_eval_completion_to_retval (jerry_api_value_t *retval_p, /**< [ | |||
| * code execution */ | |||
| { | |||
| jerry_completion_code_t ret_code; | |||
| jerry_api_convert_ecma_value_to_api_value (retval_p, completion); | |||
There was a problem hiding this comment.
Now that this function is being touched, it would be nice to update its doc comment. The "Note:" part could better be referring to jerry_api_release_value.
Another stylistic suggestion: the below 10 lines could be written in a single line...
return !ecma_is_value_error (completion) ? JERRY_COMPLETION_CODE_OK : JERRY_COMPLETION_CODE_UNHANDLED_EXCEPTION;Much cleaner. (And still within the 120 chars-per-line limit.)
There was a problem hiding this comment.
@akiss77, +1
If it is too long, then write like this:
return !ecma_is_value_error (completion) ? JERRY_COMPLETION_CODE_OK
: JERRY_COMPLETION_CODE_UNHANDLED_EXCEPTION;
|
LGTM otherwise (FWIW) |
| jerry_api_value_t ret_val; | ||
| ret_code = jerry_api_eval (buffer, len, false, false, &ret_val); | ||
|
|
||
| if (ret_code == JERRY_COMPLETION_CODE_OK) | ||
| /* Print return value */ | ||
| const jerry_api_value_t args[] = {ret_val}; |
There was a problem hiding this comment.
Please add a space before and after ret_val.
|
LGTM after comments being fixed. |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
dbatyai
force-pushed
the
print_errors_in_repl
branch
from
6eaeb9a to
37333e2
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu