Add help flag and usage to UNIX Jerry standalone. #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static void | ||
| print_usage () | ||
| { | ||
| printf ("Usage: ./jerry [flags] [js-file ...]\n" |
There was a problem hiding this comment.
Better to use argv[0] instead of ./jerry, IMHO.
|
@akiss77, I've updated the patch, the format now falls more in line with other tools. |
| { | ||
| save_snapshot_file_name_p = argv[i]; | ||
| } | ||
| else | ||
| { | ||
| JERRY_ERROR_MSG ("Error: wrong format of the arguments\n"); | ||
| JERRY_ERROR_MSG ("Error: no file specified for %s\n", argv[i-1]); |
There was a problem hiding this comment.
Oh, my bad. We are using spaces around operators. So, it's i - 1. (I know, I was the one who wrote i-1 in the review. Sorry :( )
|
Even though I might seem picky (which I know I am), I think that the patch is improving in the right direction. And it is needed. |
dbatyai
force-pushed
the
add_help_flag
branch
2 times, most recently
from
9d516ea to
0b66854
Compare
|
It's okay to be picky :). Updated again. |
|
Thanks for the rewrites. Now: LGTM (FWIW) |
|
LGTM |
|
(Please, rebase to current master) |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
|
@akiss77, Done. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu