fix: handle empty urls when append_slash=True

Author: jerivas

demo/demo/urls_with_slash.py

@@ -0,0 +1,11 @@
+"""Same as urls.py, but with `append_slash=True`"""
+
+from django.contrib import admin
+from django.urls import path
+
+from file_router import file_patterns
+
+urlpatterns = [
+    path("admin/", admin.site.urls),
+    *file_patterns("demo/views", append_slash=True),
+]

demo/demo/views_test.py

@@ -9,6 +9,22 @@ def color():
     return Color.objects.create(name="Foo Color", slug="foo", code="00ff00")
 
 
+def test_not_a_view(client):
+    with pytest.raises(NoReverseMatch):
+        reverse("not_a_view")
+
+    response = client.get("/not-a-view")
+    assert response.status_code == 404
+
+
+def test_append_slash(settings):
+    settings.ROOT_URLCONF = "demo.urls_with_slash"
+    assert reverse("home") == "/"
+    assert reverse("colors") == "/colors/"
+    assert reverse("colors_add") == "/colors/add/"
+    assert reverse("colors_slug", args=["abc"]) == "/colors/abc/"
+
+
 def test_home(client):
     url = reverse("home")
     assert (
@@ -29,14 +45,6 @@ def test_current_time(client):
     assert response.status_code == 200
 
 
-def test_not_a_view(client):
-    with pytest.raises(NoReverseMatch):
-        reverse("not_a_view")
-
-    response = client.get("/not-a-view")
-    assert response.status_code == 404
-
-
 @pytest.mark.django_db
 def test_colors(client, color):
     url = reverse("colors")

file_router/__init__.py

@@ -47,7 +47,7 @@ def file_patterns(start_dir, append_slash=False):
             except AttributeError:
                 url = "" if file == "__init__.py" else file.replace(".py", "")
                 url = start_dir_re.sub("", f"{root}/{url}").strip("/")
-                url = (url + "/") if append_slash else url
+                url = (url + "/") if append_slash and url != "" else url
 
             try:
                 urlname = view_fn.urlname