jerfowler
diff --git a/‎.claude/agents/senior-backend-engineer.md‎
Lines changed: 60 additions & 0 deletions b/‎.claude/agents/senior-backend-engineer.md‎
Lines changed: 60 additions & 0 deletions
diff --git a/‎.claude/aliases/verification-aliases.sh‎
Lines changed: 177 additions & 0 deletions b/‎.claude/aliases/verification-aliases.sh‎
Lines changed: 177 additions & 0 deletions
@@ -42,6 +42,66 @@ You practice **MCP-driven development** with TypeScript best practices:
 - **Context Abstraction**: Hide file operations, expose clean agent interfaces
 - **Production Quality**: Security-first, performance-optimized, enterprise-grade
 
+## **🚨 CRITICAL: Test Error Prevention System**
+
+**MANDATORY READING**: Before ANY test-related work, you MUST review and follow:
+- **`TEST-ERROR-PATTERNS.md`** - Database of banned error patterns
+- **`TEST-GUIDELINES.md`** - Comprehensive mandatory requirements
+
+### **Zero Tolerance Violations**
+
+**❌ IMMEDIATELY BANNED - These patterns cause instant CI/CD failure:**
+
+1. **'any' Types in Tests**: 
+   ```typescript
+   // ❌ BANNED: const server = mockServer as any;
+   // ✅ REQUIRED: const server = mockServer as unknown as ServerWithPrivates;
+   ```
+
+2. **Logical OR for Defaults**:
+   ```typescript
+   // ❌ BANNED: const value = someValue || defaultValue;
+   // ✅ REQUIRED: const value = someValue ?? defaultValue;
+   ```
+
+3. **Missing Configuration Validation**:
+   ```typescript
+   // ❌ BANNED: Test expects error but no validation exists
+   // ✅ REQUIRED: Implement validateRequiredConfig() in all tools
+   ```
+
+4. **Invalid Test Plans**:
+   ```typescript
+   // ❌ BANNED: const plan = "Simple task";
+   // ✅ REQUIRED: Detailed plans with >50 chars, checkboxes, structure
+   ```
+
+5. **Incomplete Mock Setup**:
+   ```typescript
+   // ❌ BANNED: Missing INIT.md, PLAN.md mocks
+   // ✅ REQUIRED: Mock ALL required files for proper task initialization
+   ```
+
+### **Pre-Work Validation Checklist**
+
+Before writing ANY test code, you MUST verify:
+- [ ] **Reviewed TEST-ERROR-PATTERNS.md** for banned patterns
+- [ ] **Will not use 'any' types anywhere** in test files
+- [ ] **Will use nullish coalescing (`??`)** instead of logical OR (`||`)
+- [ ] **Will implement actual validation** for tests expecting errors
+- [ ] **Will create detailed test plans** with proper format
+- [ ] **Will mock all required dependencies** (INIT.md, PLAN.md, services)
+
+### **Pattern-Specific Enforcement**
+
+**Type Assertions**: Use `as unknown as SpecificType` pattern, never `as any`
+**ESLint Compliance**: All tests must pass `npm run lint` with zero warnings
+**Configuration Tests**: Every error-expecting test must have runtime validation
+**Mock Completeness**: Include ALL required files in test setup
+**Plan Validation**: Test plans must meet `isValidPlanFormat()` requirements
+
+**CRITICAL**: Violation of these patterns will result in pre-commit hook failure and immediate work stoppage.
+
 ### MCP Tool Development Principles
 
 **Clean Tool Architecture**: Every MCP tool follows consistent patterns for reliability and maintainability.
 
@@ -0,0 +1,177 @@
+#!/bin/bash
+# Verification Functions - Replace Shortcut Commands with Proper Solutions
+# These functions redirect common bypass patterns to correct approaches
+
+# Git bypass prevention functions
+git-no-verify() {
+    echo "❌ REASONING VIOLATION: Why bypass pre-commit validation?"
+    echo "✅ PROPER APPROACH: Fix the issues that pre-commit detected"
+    echo "Run: git status && npm run ci"
+}
+
+git-skip-hooks() {
+    echo "❌ REASONING VIOLATION: Why skip validation hooks?"
+    echo "✅ PROPER APPROACH: Make your changes pass all quality gates"
+    echo "Run: npm run lint:fix && npm test"
+}
+
+# ESLint bypass prevention functions
+eslint-disable() {
+    echo "❌ REASONING VIOLATION: Why disable code quality rules?"
+    echo "✅ PROPER APPROACH: Fix the code to meet quality standards"
+    echo "Run: npm run lint:fix"
+}
+
+eslint-ignore() {
+    echo "❌ REASONING VIOLATION: Why ignore code quality warnings?"
+    echo "✅ PROPER APPROACH: Address the underlying code issues"
+    echo "Run: npm run lint && fix reported issues"
+}
+
+# TypeScript bypass prevention functions
+ts-ignore() {
+    echo "❌ REASONING VIOLATION: Why ignore type safety?"
+    echo "✅ PROPER APPROACH: Fix type issues to ensure runtime safety"
+    echo "Run: npm run type-check && fix type errors"
+}
+
+ts-nocheck() {
+    echo "❌ REASONING VIOLATION: Why disable type checking?"
+    echo "✅ PROPER APPROACH: Use proper TypeScript types"
+    echo "Run: npm run type-check"
+}
+
+ts-any() {
+    echo "❌ REASONING VIOLATION: Why use unsafe any type?"
+    echo "✅ PROPER APPROACH: Use specific types or unknown"
+    echo "Check: TypeScript handbook for proper typing"
+}
+
+# Test bypass prevention functions
+skip-test() {
+    echo "❌ REASONING VIOLATION: Why skip tests instead of fixing them?"
+    echo "✅ PROPER APPROACH: Make tests pass by fixing the underlying issues"
+    echo "Run: npm test && fix failing tests"
+}
+
+skip-tests() {
+    echo "❌ REASONING VIOLATION: Why skip test validation?"
+    echo "✅ PROPER APPROACH: Ensure all tests pass"
+    echo "Run: npm test"
+}
+
+lower-threshold() {
+    echo "❌ REASONING VIOLATION: Why lower quality standards?"
+    echo "✅ PROPER APPROACH: Improve code quality to meet existing standards"
+    echo "Run: npm run test:coverage && add missing tests"
+}
+
+# Quality gate bypass prevention functions
+disable-coverage() {
+    echo "❌ REASONING VIOLATION: Why disable coverage checking?"
+    echo "✅ PROPER APPROACH: Write comprehensive tests"
+    echo "Run: npm run test:coverage && add tests for uncovered code"
+}
+
+reduce-coverage() {
+    echo "❌ REASONING VIOLATION: Why reduce coverage requirements?"
+    echo "✅ PROPER APPROACH: Improve test coverage"
+    echo "Run: npm run test:coverage && write missing tests"
+}
+
+# Workaround prevention functions
+workaround() {
+    echo "❌ REASONING VIOLATION: Why create workarounds?"
+    echo "✅ PROPER APPROACH: Solve the actual problem causing the issue"
+    echo "Analyze: What is the root cause of this problem?"
+}
+
+quick-fix() {
+    echo "❌ REASONING VIOLATION: Why use temporary fixes?"
+    echo "✅ PROPER APPROACH: Implement the correct long-term solution"
+    echo "Think: What is the proper way to solve this?"
+}
+
+temporary-fix() {
+    echo "❌ REASONING VIOLATION: Why create temporary solutions?"
+    echo "✅ PROPER APPROACH: Fix the problem correctly now"
+    echo "Plan: Design the proper solution from the start"
+}
+
+# Proper solution command functions
+proper-git() {
+    echo "✅ PROPER GIT WORKFLOW:"
+    echo "1. git status - Check what changed"
+    echo "2. npm run ci - Verify all quality gates pass"
+    echo "3. git add . - Stage verified changes"
+    echo "4. git commit -m \"descriptive message\" - Commit with context"
+    echo "5. git push - Share your quality work"
+}
+
+proper-eslint() {
+    echo "✅ PROPER ESLINT WORKFLOW:"
+    echo "1. npm run lint - Check current issues"
+    echo "2. npm run lint:fix - Auto-fix what can be fixed"
+    echo "3. Manually fix remaining issues using proper patterns"
+    echo "4. npm run lint - Verify all issues resolved"
+    echo "5. Commit: Code now meets quality standards"
+}
+
+proper-typescript() {
+    echo "✅ PROPER TYPESCRIPT WORKFLOW:"
+    echo "1. npm run type-check - Identify type errors"
+    echo "2. Fix types using proper TypeScript patterns"
+    echo "3. Use fs-extra-safe instead of direct fs-extra"
+    echo "4. Avoid any types - use specific types"
+    echo "5. npm run type-check - Verify all types correct"
+}
+
+proper-testing() {
+    echo "✅ PROPER TESTING WORKFLOW:"
+    echo "1. npm test - Run all tests"
+    echo "2. Fix failing tests by addressing root causes"
+    echo "3. npm run test:coverage - Check coverage"
+    echo "4. Add tests for uncovered code"
+    echo "5. npm test - Verify 95%+ coverage achieved"
+}
+
+root-cause() {
+    echo "🔍 ROOT CAUSE ANALYSIS PROTOCOL:"
+    echo "1. What is the exact error message?"
+    echo "2. What component/system is affected?"
+    echo "3. What is the underlying technical cause?"
+    echo "4. Why did this occur?"
+    echo "5. How do we fix the actual problem?"
+}
+
+proper-solution() {
+    echo "🛠️ PROPER SOLUTION DESIGN:"
+    echo "1. What is the correct way to solve this?"
+    echo "2. How does this meet all quality standards?"
+    echo "3. What are the potential side effects?"
+    echo "4. How will we verify this works?"
+    echo "5. Is this a sustainable long-term solution?"
+}
+
+# Verification command functions
+verify-quality() {
+    echo "✅ QUALITY VERIFICATION:"
+    echo "npm run ci - Complete quality pipeline"
+    echo "npm run type-check - TypeScript validation"
+    echo "npm run lint - Code quality"
+    echo "npm run test - All tests pass"
+    echo "npm run test:coverage - 95%+ coverage"
+}
+
+verify-reasoning() {
+    echo "🧠 REASONING VERIFICATION:"
+    echo "□ Have I identified the root cause?"
+    echo "□ Am I fixing the actual problem?"
+    echo "□ Will this meet all quality standards?"
+    echo "□ Am I avoiding shortcuts/bypasses?"
+    echo "□ Is this a proper long-term solution?"
+}
+
+# Installation confirmation
+echo "🛡️ Verification functions loaded - shortcuts redirected to proper solutions"
+echo "Use 'proper-git', 'proper-eslint', 'root-cause', 'verify-quality' for guidance"