Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ignore_format_strict output + actual usage in ignore file + list_unused_filters: true #532

Open
Nezteb opened this issue Feb 8, 2024 · 0 comments
Labels

Comments

@Nezteb
Copy link
Contributor

Nezteb commented Feb 8, 2024

Current behavior

I added this new ignore file format in #493 and only recently have had a chance to test this in the wild along with list_unused_filters: true. It works for many error descriptions, unless they contain newlines.

If any of the error descriptions for your project contains newlines, you copy-paste the --format ignore_format_strict output into your .dialyzer_ignore.exs, and you re-run mix dialyzer you will get failures about unused filters. Newlines often show up in multi-line code snippets, and the string handling I added doesn't handle newlines appropriately. I don't have any good examples I can copy paste at the moment. 😅

Expected behavior

When comparing the ignorefile line with the incoming error description, I think we can just replace all whitespace with spaces and then trim duplicates?

I have a branch working on the fix, but I find myself running out of free time more and more.

@jeremyjh jeremyjh added the bug label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants