From 65007a04bdf1646713a79b8eb7b8c3c4fd15b0d2 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 19 Jan 2021 13:22:45 -0500 Subject: [PATCH 1/4] Remove InfoCard :height100" variant --- .../core/src/layout/InfoCard/InfoCard.tsx | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/packages/core/src/layout/InfoCard/InfoCard.tsx b/packages/core/src/layout/InfoCard/InfoCard.tsx index 5d77f4f34a487..af10010d14fec 100644 --- a/packages/core/src/layout/InfoCard/InfoCard.tsx +++ b/packages/core/src/layout/InfoCard/InfoCard.tsx @@ -76,26 +76,11 @@ const VARIANT_STYLES = { height: 'calc(100% - 10px)', // for pages without content header marginBottom: '10px', }, - /** - * @deprecated This variant is replaced by 'gridItem'. - */ - height100: { - display: 'flex', - flexDirection: 'column', - height: 'calc(100% - 10px)', // for pages without content header - marginBottom: '10px', - }, }, cardContent: { fullHeight: { flex: 1, }, - /** - * @deprecated This variant is replaced by 'gridItem'. - */ - height100: { - flex: 1, - }, gridItem: { flex: 1, }, @@ -167,12 +152,6 @@ export const InfoCard = ({ if (variant) { const variants = variant.split(/[\s]+/g); variants.forEach(name => { - if (name === 'height100') { - // eslint-disable-next-line no-console - console.warn( - "Variant 'height100' of InfoCard is deprecated. Use variant 'gridItem' instead.", - ); - } calculatedStyle = { ...calculatedStyle, ...VARIANT_STYLES.card[name as keyof typeof VARIANT_STYLES['card']], From efd6ef7530ce71dfd919431411e51f076f3cd10e Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 19 Jan 2021 13:25:18 -0500 Subject: [PATCH 2/4] Add changeset --- .changeset/calm-turtles-smoke.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/calm-turtles-smoke.md diff --git a/.changeset/calm-turtles-smoke.md b/.changeset/calm-turtles-smoke.md new file mode 100644 index 0000000000000..4d56aca85433c --- /dev/null +++ b/.changeset/calm-turtles-smoke.md @@ -0,0 +1,7 @@ +--- +'@backstage/core': patch +--- + +Removed InfoCard variant "height100", originally deprecated in [#2826](https://github.com/backstage/backstage/pull/2826). + +If your component still relies on this variant, simply replace it with "gridItem". From a0a1e8860e9b250fda72f1188c968d744dc54161 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 19 Jan 2021 13:30:57 -0500 Subject: [PATCH 3/4] Add codefences to changeset --- .changeset/calm-turtles-smoke.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/calm-turtles-smoke.md b/.changeset/calm-turtles-smoke.md index 4d56aca85433c..be271e28ad613 100644 --- a/.changeset/calm-turtles-smoke.md +++ b/.changeset/calm-turtles-smoke.md @@ -2,6 +2,6 @@ '@backstage/core': patch --- -Removed InfoCard variant "height100", originally deprecated in [#2826](https://github.com/backstage/backstage/pull/2826). +Removed `InfoCard` variant `height100`, originally deprecated in [#2826](https://github.com/backstage/backstage/pull/2826). -If your component still relies on this variant, simply replace it with "gridItem". +If your component still relies on this variant, simply replace it with `gridItem`. From 6effc8f75f4d3cd4d2c0f07ceb55a35620e4949b Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 19 Jan 2021 13:37:27 -0500 Subject: [PATCH 4/4] Make breaking 'minor' change' --- .changeset/calm-turtles-smoke.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/calm-turtles-smoke.md b/.changeset/calm-turtles-smoke.md index be271e28ad613..f2d473fe9f962 100644 --- a/.changeset/calm-turtles-smoke.md +++ b/.changeset/calm-turtles-smoke.md @@ -1,5 +1,5 @@ --- -'@backstage/core': patch +'@backstage/core': minor --- Removed `InfoCard` variant `height100`, originally deprecated in [#2826](https://github.com/backstage/backstage/pull/2826).