test: reorganize tests and fixtures

Author: jeremyben

__fixtures__/basic-with-other/src/excluded/bar.ts

@@ -0,0 +1,3 @@
+import { pseudoRandomBytes } from 'crypto'
+
+const bar = pseudoRandomBytes(64).toString('utf8')

__fixtures__/basic-with-other/src/excluded/foo.ts

@@ -0,0 +1,3 @@
+import { pseudoRandomBytes } from 'crypto'
+
+const foo = pseudoRandomBytes(32).toString('utf8')

__fixtures__/src/excluded/other-excluded/data.json renamed to __fixtures__/basic-with-other/src/excluded/other-excluded/data.json

@@ -0,0 +1,7 @@
+import { hello } from './second'
+
+export const variable = 1
+
+export const greet = () => {
+	console.log(hello)
+}

__fixtures__/src/main.js renamed to __fixtures__/basic-with-other/src/main.js

@@ -0,0 +1 @@
+export const hello = 'Hello World'

__fixtures__/basic-with-other/src/main.ts

@@ -0,0 +1,13 @@
+{
+	"compilerOptions": {
+		"target": "es2017",
+		"module": "commonjs",
+		"lib": ["es2017"],
+		"rootDir": "./src",
+		"outDir": "./dist",
+		"strict": true,
+		"moduleResolution": "node",
+		"esModuleInterop": true,
+		"resolveJsonModule": true
+	}
+}

__fixtures__/src/other/data.json renamed to __fixtures__/basic-with-other/src/other/data.json

@@ -0,0 +1,3 @@
+import { pseudoRandomBytes } from 'crypto'
+
+const bar = pseudoRandomBytes(64).toString('utf8')

__fixtures__/src/other/logic.js renamed to __fixtures__/basic-with-other/src/other/logic.js

@@ -0,0 +1,3 @@
+import { pseudoRandomBytes } from 'crypto'
+
+const foo = pseudoRandomBytes(32).toString('utf8')

__fixtures__/src/other/view.html renamed to __fixtures__/basic-with-other/src/other/view.html

@@ -0,0 +1,7 @@
+import { hello } from './second'
+
+export const variable = 1
+
+export const greet = () => {
+	console.log(hello)
+}

__fixtures__/basic-with-other/src/second.ts

@@ -0,0 +1 @@
+export const hello = 'Hello World'

__fixtures__/basic-with-other/tsconfig.json

@@ -0,0 +1,13 @@
+{
+	"compilerOptions": {
+		"target": "es2017",
+		"module": "commonjs",
+		"lib": ["es2017"],
+		"rootDir": "./src",
+		"outDir": "./dist",
+		"strict": true,
+		"moduleResolution": "node",
+		"esModuleInterop": true,
+		"resolveJsonModule": true
+	}
+}

__fixtures__/basic/src/excluded/bar.ts

@@ -0,0 +1,4 @@
+{
+	"jsonFixture": null,
+	"default": 1
+}

__fixtures__/basic/src/excluded/foo.ts

@@ -36,7 +36,7 @@ type KV = {
  * @internal
  */
 export const isObservable: (obj: KV) => boolean = (obj) => {
-	return !!obj && (isFunction(obj.lift) && isFunction(obj.subscribe))
+	return !!obj && isFunction(obj.lift) && isFunction(obj.subscribe)
 }
 
 export const isObs = isObservable
@@ -91,8 +91,8 @@ export function OverloadedDecorator(): ParameterDecorator {
 	return (target, methodKey, index) => undefined
 }
 
-export { jsonFixture as fixture } from '../other/data.json'
-// import { jsonFixture as fixture } from '../other/data.json'
+export { jsonFixture as fixture } from '../data.json'
+// import { jsonFixture as fixture } from '../data.json'
 // export { fixture }
-import * as jsonFile from '../other/data.json'
+import * as jsonFile from '../data.json'
 export { jsonFile }

__fixtures__/basic/src/main.ts

@@ -0,0 +1,64 @@
+import { join } from 'path'
+import { existsSync } from 'fs'
+import { createProgramFromConfig, build } from '../src'
+import { rmrf } from '../src/utils/fs'
+
+const basePath = join(__dirname, '..', '__fixtures__', 'basic')
+
+afterEach(() => {
+	rmrf(join(basePath, 'dist'))
+})
+
+test('Create program by overriding config file', async () => {
+	const consoleWarnSpy = spyOn(console, 'warn')
+
+	const program = createProgramFromConfig({
+		basePath,
+		configFilePath: 'tsconfig.json',
+		compilerOptions: {
+			rootDir: 'src',
+			outDir: 'dist',
+			declaration: 'true' as any,
+			skipLibCheck: true,
+		},
+		exclude: ['**/excluded', '**/dist'],
+	})
+
+	expect(program.getCompilerOptions()).toMatchObject({
+		strict: true,
+		// `compilerOptions` properties returns unix separators in windows paths
+		rootDir: join(basePath, 'src').replace(/\\/g, '/'),
+		declaration: undefined,
+	})
+
+	expect(consoleWarnSpy).toHaveBeenCalledWith(expect.stringContaining("'declaration' requires a value of type boolean"))
+
+	expect(program.getRootFileNames()).toHaveLength(2)
+})
+
+test('Build without errors with config from scratch', async () => {
+	const consoleWarnSpy = spyOn(console, 'warn')
+
+	build({
+		basePath,
+		compilerOptions: {
+			module: 'commonjs',
+			moduleResolution: 'node',
+			target: 'es2019',
+			lib: ['es2019'],
+			rootDir: 'src',
+			outDir: 'dist',
+			resolveJsonModule: true,
+			// listEmittedFiles: true,
+			esModuleInterop: true,
+			listFiles: true,
+			declaration: true,
+			skipLibCheck: true,
+		},
+	})
+
+	expect(consoleWarnSpy).not.toHaveBeenCalledWith(expect.stringContaining('error'))
+
+	const distMainFile = join(basePath, 'dist', 'main.js')
+	expect(existsSync(distMainFile)).toBe(true)
+})

__fixtures__/basic/src/second.ts

@@ -0,0 +1,19 @@
+import { join } from 'path'
+import { build } from '../src'
+
+const basePath = join(__dirname, '..', '__fixtures__', 'bundle-complex')
+
+test.skip('bundle', () => {
+	build({
+		basePath,
+		configFilePath: 'tsconfig.json',
+		compilerOptions: {
+			declaration: true,
+			listEmittedFiles: true,
+		},
+		exclude: ['**/excluded'],
+		bundleDeclaration: {
+			entryPoint: 'main.d.ts',
+		},
+	})
+})

__fixtures__/basic/tsconfig.json

@@ -0,0 +1,59 @@
+import { join } from 'path'
+import { build } from '../src'
+
+const basePath = join(__dirname, '..', '__fixtures__', 'basic')
+
+// Mock deleting folders for protection
+jest.mock('../src/utils/fs', () => ({
+	...jest.requireActual('../src/utils/fs'),
+	rmrf: jest.fn((path) => console.info('mock rmrf on', path)),
+}))
+
+// Need actual delete implementation to clean between some tests.
+// Can't unmock implicit imports on a per test basis https://github.com/facebook/jest/issues/2649
+afterEach(() => {
+	const { rmrf } = jest.requireActual('../src/utils/fs')
+	const outDirPaths = [join(basePath, 'dist'), join(basePath, 'src', 'dist')]
+	outDirPaths.forEach(rmrf)
+})
+
+describe('Clean protections', () => {
+	test('Forbid cleaning rootDir', async () => {
+		expect(() => {
+			build({
+				basePath,
+				configFilePath: 'tsconfig.json',
+				compilerOptions: { rootDir: 'src' },
+				clean: ['src'],
+			})
+		}).toThrow('cannot delete')
+	})
+
+	test('Forbid cleaning basePath and up', async () => {
+		expect(() => {
+			build({
+				basePath,
+				configFilePath: 'tsconfig.json',
+				clean: ['.'],
+			})
+		}).toThrow('cannot delete')
+
+		expect(() => {
+			build({
+				basePath,
+				configFilePath: 'tsconfig.json',
+				clean: ['..'],
+			})
+		}).toThrow('cannot delete')
+	})
+
+	test('Forbid cleaning cwd', async () => {
+		expect(() => {
+			build({
+				basePath,
+				configFilePath: 'tsconfig.json',
+				clean: [process.cwd()],
+			})
+		}).toThrow('cannot delete')
+	})
+})

__fixtures__/bundle-complex/src/data.json

@@ -0,0 +1,52 @@
+import { existsSync, readdirSync } from 'fs'
+import { join } from 'path'
+import { build } from '../src'
+import { rmrf } from '../src/utils/fs'
+
+const basePath = join(__dirname, '..', '__fixtures__', 'basic-with-other')
+
+afterEach(() => {
+	rmrf(join(basePath, 'dist'))
+	rmrf(join(basePath, 'src', 'dist'))
+})
+
+describe('Copy addon', () => {
+	test('all other files', () => {
+		const expectedOtherFiles = readdirSync(join(basePath, 'src', 'other'))
+		const consoleInfoSpy = spyOn(console, 'info')
+
+		build({
+			basePath,
+			configFilePath: 'tsconfig.json',
+			copyOtherToOutDir: true,
+			exclude: ['**/excluded'],
+		})
+
+		const otherDirDistPath = join(basePath, 'dist', 'other')
+		expect(readdirSync(otherDirDistPath)).toHaveLength(expectedOtherFiles.length)
+
+		const excludedDirDistPath = join(basePath, 'dist', 'excluded')
+		expect(existsSync(excludedDirDistPath)).toBe(false)
+
+		expect(consoleInfoSpy).toHaveBeenCalledWith(expect.stringMatching(/override.*main\.js/))
+	})
+
+	test('do not recursively copy outDir to outDir', () => {
+		// tslint:disable-next-line: no-shadowed-variable
+		const basePath = join(__dirname, '..', '__fixtures__', 'basic-with-other', 'src')
+
+		build({
+			basePath,
+			configFilePath: '../tsconfig.json',
+			copyOtherToOutDir: true,
+			compilerOptions: {
+				rootDir: '.',
+				outDir: 'dist',
+			},
+			exclude: ['**/excluded'],
+		})
+
+		const distInDist = join(basePath, 'dist', 'dist')
+		expect(existsSync(distInDist)).toBe(false)
+	})
+})

__fixtures__/src/main.ts renamed to __fixtures__/bundle-complex/src/main.ts

@@ -2,11 +2,14 @@
 const config = {
 	preset: 'ts-jest',
 	testEnvironment: 'node',
-	testPathIgnorePatterns: ['/node_modules/', '/__fixtures__/'],
+	roots: ['<rootDir>/src/', '<rootDir>/__tests__/'],
+	testPathIgnorePatterns: ['/node_modules/', '/__fixtures__/', '.*\\.d\\.ts$'],
 	globals: {
 		'ts-jest': {
 			diagnostics: {
-				warnOnly: true, // https://kulshekhar.github.io/ts-jest/user/config/diagnostics
+				// https://kulshekhar.github.io/ts-jest/user/config/diagnostics
+				warnOnly: true,
+				pretty: false,
 			},
 		},
 	},