Skip to content

Passport v13 support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Passport v13 support #37

merged 1 commit into from
May 20, 2025

Conversation

alecpl
Copy link
Contributor

@alecpl alecpl commented May 20, 2025

Also

  • fixed PHP Fatal error: Declaration of OpenIDConnect\Interfaces\IdentityEntityInterface::getIdentifier() must be compatible with League\OAuth2\Server\Entities\UserEntityInterface::getIdentifier(): string
  • bumped phpunit to v10 (fixes warnings about the config file).

ps. I did not test if it works in a real life application, but tests here pass.

Also fixed PHP Fatal error: Declaration of OpenIDConnect\Interfaces\IdentityEntityInterface::getIdentifier() must be compatible with League\OAuth2\Server\Entities\UserEntityInterface::getIdentifier(): string
Also bumped phpunit to v10 (fixes warnings about the config file).
@alecpl
Copy link
Contributor Author

alecpl commented May 20, 2025

Looks like on PHP 8.1 we're using league/oauth2-server v8 not v9. And it is the problem with test failure on PHP 8.1.

@jeremy379
Copy link
Owner

Thanks for this PR
We can drop support for PHP 8.1 in a new version :) I'll release a new major.

@alecpl
Copy link
Contributor Author

alecpl commented May 20, 2025

league/oauth2-server v9 supports PHP 8.1, so I'm not sure why we get v8 in tests. Maybe we could fix this somehow other than bumping min PHP version requirement.

@jeremy379 jeremy379 merged commit 0bb61d1 into jeremy379:main May 20, 2025
3 of 4 checks passed
@alecpl
Copy link
Contributor Author

alecpl commented May 20, 2025

@jeremy379 You're too fast. You did not bump PHP version in composer.json.

@alecpl
Copy link
Contributor Author

alecpl commented May 20, 2025

Seems that we no longer support league/oauth2-server v8, therefore we only support Passport v13. Not great situation, but if you're fine with it we should cleanup the composer.json.

@coffe4u
Copy link
Contributor

coffe4u commented May 22, 2025

I'm getting this:

PHP Fatal error:  Declaration of OpenIDConnect\Laravel\PassportServiceProvider::boot() must be compatible with Laravel\Passport\PassportServiceProvider::boot(): void in /home/runner/work/cps-staff-portal/cps-staff-portal/vendor/jeremy379/laravel-openid-connect/src/Laravel/PassportServiceProvider.php on line 30

This PR laravel/passport#1788 added the void return type to the boot method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants