Fix bug where having branch wildcards at different depths would cause ArrayBoundExceptions #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ArrayBoundExceptions
|
@frankier Is there any Jira issue for that? |
jglick
requested changes
Jun 16, 2017
|
Without knowing the stacktrace, it's hard to decide. The patch seems to be valid, but I agree with previous reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example use case of this is the Jenkins Multibranch Pipeline to try and find stuff to build in a chaotic monorepo. I set "Include branches" to: trunk,branches/,branches//,branches///,branches////,tags/* and got an indexing exception. This patch seems to fix it.