Merge pull request #256 from jenkinsci/replace-RUN_SCRIPTS-with-ADMINISTER

replace RUN_SCRIPTS with ADMINISTER

Author: jglick

src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/BasicSSHUserPrivateKey.java

@@ -443,7 +443,7 @@ private Object readResolve() {
                 return new DirectEntryPrivateKeySource(privateKeyFile);
             }
 
-            Jenkins.get().checkPermission(Jenkins.RUN_SCRIPTS);
+            Jenkins.get().checkPermission(Jenkins.ADMINISTER);
 
             LOGGER.log(Level.INFO, "SECURITY-440: Migrating FileOnMasterPrivateKeySource to DirectEntryPrivateKeySource");
             // read the content of the file and then migrate to Direct
@@ -530,7 +530,7 @@ public long getPrivateKeysLastModified() {
         }
 
         private Object readResolve() {
-            Jenkins.get().checkPermission(Jenkins.RUN_SCRIPTS);
+            Jenkins.get().checkPermission(Jenkins.ADMINISTER);
 
             LOGGER.log(Level.INFO, "SECURITY-440: Migrating UsersPrivateKeySource to DirectEntryPrivateKeySource");
             // read the content of the file and then migrate to Direct

src/test/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/BasicSSHUserPrivateKeyTest.java

@@ -98,7 +98,7 @@ public void userWithoutRunScripts_cannotMigrateDangerousPrivateKeySource() throw
                     .withStdin(updateFolder.read())
                     .invokeWithArgs("folder1");
 
-            assertThat(result.stderr(), containsString("user is missing the Overall/RunScripts permission"));
+            assertThat(result.stderr(), containsString("user is missing the Overall/Administer permission"));
             assertThat(result, failedWith(1));
 
             // config file not touched