-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable retry delay and jitter #676
base: master
Are you sure you want to change the base?
Conversation
@rahulsom I seem to recall you mentioning this problem before; would this remove your need for any custom wrappers? |
Thanks! This is nice. It should allow me to rely on this instead of custom logic. |
@rahulsom Are you interested in ripping our your custom logic in favor of the incremental build from this PR to validate that it works? |
I'm on a brief break but will test it out sometime next week. Is that cool? |
Sure, thanks! |
@rahulsom Are you still interested in kicking the tires on this? |
Sorry about the delay! |
@rahulsom Reconnect can be triggered easily by restarting the controller while inbound agent(s) are connected. For example, create an agent in the UI with a Launch method of Launch agent by connecting it to the controller, then download the incremental build of Remoting from this PR and run When multiple agents are launched at the same time and the controller subsequently restarts, all agents should notice and start reconnecting at the same time, creating a thundering herd. The new jitter functionality being introduced in this PR can then be used to solve the thundering herd problem via the newly-introduced |
Allow the retry delay to be configured rather than hard-coded to 10 seconds, and allow the fixed delay to be combined with jitter to help avoid thundering herds.