Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POM updates #12

Merged
merged 11 commits into from
Nov 15, 2018
Merged

POM updates #12

merged 11 commits into from
Nov 15, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 14, 2018

In #11 it was brought to my attention that #10 had been merged but did not actually work. Fixing that.

(The root issue was CRLF translation in what was supposed to be a binary file. Maybe a file with LF and no NUL is assumed to be textual?)

@jglick
Copy link
Member Author

jglick commented Nov 14, 2018

Hmm, test is passing for me on Windows 10.

@jglick
Copy link
Member Author

jglick commented Nov 15, 2018

At last a clue:

java.lang.Error: Failed to load the key: org.jenkinsci.plugins.plaincredentials.impl.FileCredentialsImpl
	at jenkins.security.CryptoConfidentialKey.getKey(CryptoConfidentialKey.java:53)
	at jenkins.security.CryptoConfidentialKey.decrypt(CryptoConfidentialKey.java:134)
	at org.jenkinsci.plugins.plaincredentials.SecretBytesTest.migrateLegacyData(SecretBytesTest.java:120)
	at …
Caused by: java.io.IOException: javax.crypto.IllegalBlockSizeException: Input length must be multiple of 16 when decrypting with padded cipher
	at javax.crypto.CipherInputStream.getMoreData(CipherInputStream.java:121)
	at javax.crypto.CipherInputStream.read(CipherInputStream.java:239)
	at javax.crypto.CipherInputStream.read(CipherInputStream.java:215)
	at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1792)
	at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1769)
	at org.apache.commons.io.IOUtils.copy(IOUtils.java:1744)
	at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:462)
	at jenkins.security.DefaultConfidentialStore.load(DefaultConfidentialStore.java:107)
	at jenkins.security.ConfidentialKey.load(ConfidentialKey.java:47)
	at jenkins.security.CryptoConfidentialKey.getKey(CryptoConfidentialKey.java:41)
	... 15 more
Caused by: javax.crypto.IllegalBlockSizeException: Input length must be multiple of 16 when decrypting with padded cipher
	at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:936)
	at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:847)
	at com.sun.crypto.provider.AESCipher.engineDoFinal(AESCipher.java:446)
	at javax.crypto.Cipher.doFinal(Cipher.java:2047)
	at javax.crypto.CipherInputStream.getMoreData(CipherInputStream.java:118)
	... 24 more

@jglick jglick merged commit c08a375 into jenkinsci:master Nov 15, 2018
@jglick jglick deleted the updates branch November 15, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants