Read and connect timeout are now correctly used to configure the client. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
requested changes
Oct 26, 2016
|
|
||
| public KubernetesFactoryAdapter(String serviceAddress, @CheckForNull String caCertData, | ||
| @CheckForNull String credentials, boolean skipTlsVerify) { | ||
| this(serviceAddress, null, caCertData, credentials, skipTlsVerify); | ||
| @CheckForNull String credentials, boolean skipTlsVerify, int readTimeout, int connectTimeout) { |
There was a problem hiding this comment.
Can you keep backwards compatibility?
| } | ||
|
|
||
|
|
||
| public KubernetesFactoryAdapter(String serviceAddress, String namespace, @CheckForNull String caCertData, | ||
| @CheckForNull String credentials, boolean skipTlsVerify) { | ||
| @CheckForNull String credentials, boolean skipTlsVerify, int connectTimeout, int readTimeout) { |
There was a problem hiding this comment.
Can you keep backwards compatibility?
|
Tests are failing for reasons not related with the pull requests. |
|
Unfortunately I'm on vacation without my laptop and can't fix it, and github doesn't let me merge from the phone :(
|
|
No worries! Have fun!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.