Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The workspace volume is now configurable. #114

Merged
merged 1 commit into from
Jan 29, 2017
Merged

The workspace volume is now configurable. #114

merged 1 commit into from
Jan 29, 2017

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jan 3, 2017

Currently containers share workspace by accessing an empty dir volume inside the pod.

We should also allow the use of other means, like pvc, nfs and hostpath volumes.

This pull request adds an option that alllows the user to choose and configure one of the above.

This is still work in progress (still need to do some more testing), but I am creating the PR for feedback etc.

@iocanel
Copy link
Contributor Author

iocanel commented Jan 16, 2017

@carlossg: any comments?

@iocanel
Copy link
Contributor Author

iocanel commented Jan 19, 2017

One of the issues, I have with this pull request is that I can't get the optional block to work correctly (the checkbox that shows the block that lets you define a work space volume).

I am using an optionalBlock and the issue I have is that the configuration is not persisted.

@carlossg: could you help me a bit with that.

I also have the exact same issue with #117

@carlossg
Copy link
Contributor

No idea, would need to check it this weekend.

I'd check with the browser dev tools what form data is sent from the browser to the backend, that could give you a hint

@iocanel
Copy link
Contributor Author

iocanel commented Jan 19, 2017

ahhhh great idea!

@iocanel iocanel changed the title [WIP] The workspace volume is now configurable. The workspace volume is now configurable. Jan 26, 2017
@iocanel
Copy link
Contributor Author

iocanel commented Jan 26, 2017

@carlossg: I think its ready for review now.

@iocanel iocanel requested a review from carlossg January 26, 2017 10:15
@iocanel iocanel mentioned this pull request Jan 27, 2017
@carlossg
Copy link
Contributor

LGTM, I would love to have some examples in the README and some testing with minikube in KubernetesPipelineTest otherwise this is going to be a nightmare to maintain and avoid regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants