Fixing checkbox serialization by jelly views #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but since I am no jelly expert, I'd like @carlossg opinion. |
|
@iocanel you had set them as |
|
@carlossg: right! I think that the idea was to be able to check if a value has been set or not (checking against null), but I think that in the end of the day I added a default value in the constructor (which means that there was a bug there). A solution for both cases would be add a second boolean field per boolean which marks if a value has been explicitly set. Since this is a bug that was already there, I think that its fair to merge this and then fix the bug in a different pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkboxes in the PodTemplate were being reset to default state in the Views since it seems like Jelly expects the boolean primitive not the Boolean type.