Skip to content

Commit 9dd678a

Browse files
committed
Issue-361: Add prudent information about a publishing of checks.
1 parent 8d17133 commit 9dd678a

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/main/java/io/jenkins/plugins/checks/github/GitHubChecksPublisher.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,12 @@ public void publish(final ChecksDetails details) {
9696

9797
context.addActionIfMissing(run.getId(), gitHubDetails.getName());
9898

99-
buildLogger.log("GitHub check (name: %s, status: %s) has been published.", gitHubDetails.getName(),
100-
gitHubDetails.getStatus());
101-
SYSTEM_LOGGER.fine(format("Published check for repo: %s, sha: %s, job name: %s, name: %s, status: %s",
99+
buildLogger.log("GitHub check (name: %s, status: %s, url: %s) has been published.",
100+
gitHubDetails.getName(),
101+
gitHubDetails.getStatus(),
102+
gitHub.getApiUrl());
103+
SYSTEM_LOGGER.fine(format("Published check for url: %s, repo: %s, sha: %s, job name: %s, name: %s, status: %s",
104+
gitHub.getApiUrl(),
102105
context.getRepository(),
103106
context.getHeadSha(),
104107
context.getJob().getFullName(),

src/test/java/io/jenkins/plugins/checks/github/GitHubChecksPublisherITest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ public void shouldLogChecksParametersIfExceptionHappensWhenPublishChecks() {
245245
assertThat(loggerRule.getMessages().get(0))
246246
.contains("Failed Publishing GitHub checks: ")
247247
.contains("name='Jenkins'")
248+
.contains("url=foobar")
248249
.contains("status=COMPLETED")
249250
.contains("conclusion=SUCCESS")
250251
.contains("title='Jenkins Check'")

0 commit comments

Comments
 (0)