Skip to content

Commit 49fae30

Browse files
committed
[JENKINS-73312] Adapt GitHub API for Jetty 12 (EE 9)
1 parent 32cdc61 commit 49fae30

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

pom.xml

+8-2
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@
2525
<properties>
2626
<revision>1.321</revision>
2727
<changelist>999999-SNAPSHOT</changelist>
28-
<jenkins.version>2.472</jenkins.version>
28+
<jenkins.version>2.475</jenkins.version>
2929
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
3030
<no-test-jar>false</no-test-jar>
3131
<!-- TODO JENKINS-73339 until in parent POM -->
32-
<jenkins-test-harness.version>2250.v03a_1295b_0a_30</jenkins-test-harness.version>
32+
<jenkins-test-harness.version>2265.v3da_49c8134d6</jenkins-test-harness.version>
3333
<maven.compiler.release>17</maven.compiler.release>
3434
</properties>
3535

@@ -110,6 +110,12 @@
110110
<scope>import</scope>
111111
<type>pom</type>
112112
</dependency>
113+
<!-- TODO JENKINS-73339 until in parent POM, work around https://github.com/jenkinsci/plugin-pom/issues/936 -->
114+
<dependency>
115+
<groupId>jakarta.servlet</groupId>
116+
<artifactId>jakarta.servlet-api</artifactId>
117+
<version>5.0.0</version>
118+
</dependency>
113119
</dependencies>
114120
</dependencyManagement>
115121

src/test/java/jenkins/plugins/github/api/mock/MockGitHub.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@
2222
import java.util.concurrent.ThreadPoolExecutor;
2323
import java.util.concurrent.TimeUnit;
2424
import java.util.concurrent.atomic.AtomicLong;
25-
import javax.servlet.ServletException;
25+
import jakarta.servlet.ServletException;
2626
import org.eclipse.jetty.server.HttpConfiguration;
2727
import org.eclipse.jetty.server.HttpConnectionFactory;
2828
import org.eclipse.jetty.server.Server;
2929
import org.eclipse.jetty.server.ServerConnector;
30-
import org.eclipse.jetty.ee8.servlet.ServletContextHandler;
30+
import org.eclipse.jetty.ee9.servlet.ServletContextHandler;
3131
import org.jvnet.hudson.test.ThreadPoolImpl;
3232
import org.kohsuke.stapler.HttpResponse;
3333
import org.kohsuke.stapler.QueryParameter;
3434
import org.kohsuke.stapler.Stapler;
35-
import org.kohsuke.stapler.StaplerRequest;
36-
import org.kohsuke.stapler.StaplerResponse;
35+
import org.kohsuke.stapler.StaplerRequest2;
36+
import org.kohsuke.stapler.StaplerResponse2;
3737

3838
public class MockGitHub implements Closeable {
3939
private AtomicLong nextId = new AtomicLong();
@@ -178,7 +178,7 @@ public List<MockOwner<?>> owners() {
178178
public HttpResponse doRepositories(final @QueryParameter long since) {
179179
return new HttpResponse() {
180180
@Override
181-
public void generateResponse(StaplerRequest req, StaplerResponse rsp, Object node)
181+
public void generateResponse(StaplerRequest2 req, StaplerResponse2 rsp, Object node)
182182
throws IOException, ServletException {
183183
List<MockRepository> repositories = new ArrayList<>();
184184
for (MockOwner<?> o : owners()) {

0 commit comments

Comments
 (0)