Use poll env when checking for ls-remote branches. #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any update on this? |
Sorry for the delay @timbrown5 . I'll try to review it within the next 2-4 weeks. Changing the polling process has a number of areas where I need to be especially to not change (regress) existing behavior. |
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Jul 29, 2024
Incremental that includes: * Use poll env when checking for ls-remote branches jenkinsci/git-plugin#1511 * Optionally report the most recent commit as the changelog of a new build jenkinsci/git-plugin#1565 https://issues.jenkins.io/browse/JENKINS-4162 https://issues.jenkins.io/browse/JENKINS-14138 https://issues.jenkins.io/browse/JENKINS-26354 https://issues.jenkins.io/browse/JENKINS-68030 * Generate and revoke access tokens with standard UI components jenkinsci/git-plugin#1597 * Do not assume HttpResponse is a functional interface jenkinsci/git-plugin#1590
…-plugin into support_param_in_ls_remote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core issue is that params are not resolved until the start of the build (i.e. not valid in the Polling context).
The
git ls-remotecode-path uses an empty env when checking for branches - which means params in a branch spec don't get resolved.I have updated the code to use the
pollEnvvariable when evaluating these params - as these .Some additional background - we have tried the workaround of setting 'Force workspace when polling'. This seems to fix the issue for permanent nodes, but we use a lot of EC2 nodes where it breaks once the node that last ran a job gets culled.
Checklist
Types of changes