Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook comand shouldn't always executes even there's error exists #159

Open
LinuxSuRen opened this issue Sep 17, 2019 · 6 comments
Open

Hook comand shouldn't always executes even there's error exists #159

LinuxSuRen opened this issue Sep 17, 2019 · 6 comments
Assignees
@waveywaves
Labels
bug Something isn't working Hacktoberfest More details from https://hacktoberfest.digitalocean.com/
Milestone
v0.1.0

Comments

@LinuxSuRen
Copy link
Member

Describe the bug
Part of my config is below.

postHooks:
- path: plugin.upload
  cmd: jcli center watch --util-install-complete
- path: plugin.upload
  cmd: jcli restart -b

The command should stop if one of the preHooks is failed.

To Reproduce
Steps to reproduce the behavior:

  1. Add the sample which I given into you config file
  2. Execute command jcli upload under a plugin project source directory
  3. See the result

Expected behavior
The command should not be executed once if there's some thing wrong.

Screenshots
None.

Desktop (please complete the following information):

  • OS: MacOS
  • Version: dev-v0.0.19

Additional context
None.
@LinuxSuRen LinuxSuRen added the bug Something isn't working label Sep 17, 2019
@LinuxSuRen LinuxSuRen added this to the v0.0.21 milestone Sep 17, 2019
@LinuxSuRen LinuxSuRen added the Hacktoberfest More details from https://hacktoberfest.digitalocean.com/ label Sep 30, 2019
@waveywaves
Copy link

I will be working on this

@LinuxSuRen
Copy link
Member Author

@waveywaves Great! I'm going to assign this to you. And thanks for your enthusiasm.

@LinuxSuRen LinuxSuRen modified the milestones: v0.0.21, v0.0.22 Oct 15, 2019
@LinuxSuRen LinuxSuRen modified the milestones: v0.0.22, v0.0.23 Oct 30, 2019
@LinuxSuRen
Copy link
Member Author

Hi @waveywaves , just a kind reminder. Are you still interested in this?

@waveywaves
Copy link

Yes, I have started working on it.

@LinuxSuRen
Copy link
Member Author

Great, take it easy. I'm looking forward to it.

@LinuxSuRen
Copy link
Member Author

hi @waveywaves , how is it going? Do you need help from me?

@LinuxSuRen LinuxSuRen modified the milestones: v0.0.23, v0.1.0 Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waveywaves waveywaves

Labels
bug Something isn't working Hacktoberfest More details from https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@LinuxSuRen @waveywaves