Add label version in deployment specification for compatibility with istio

[msvticket]

Jenkins-X already has integrations with Istio and it seems like there are more to come. It would then make sense to improve compability with Istio.

Looking at https://istio.io/docs/setup/kubernetes/spec-requirements/ I find that the helm charts of the build packs differ from the Istio requirements by lacking a version label in the deployment specifications.

So I propose adding the label version to pod template of the deployments in the build packs.

Fixes would be done in https://github.com/jenkins-x/jx3-pipeline-catalog/tree/master/packs

[ccojocar]

@msvticket are you refereeing to build pods? Which kind of installation are you running classic or serverless?

[msvticket]

No, not build pods. Build packs. Taking maven as an example the labels app and version are missing from the deployment here https://github.com/jenkins-x-buildpacks/jenkins-x-kubernetes/blob/master/packs/maven/charts/templates/deployment.yaml

I'm not running serverless, but I don't think that matters.

[ccojocar]

Thanks. It think the app label is already there https://github.com/jenkins-x-buildpacks/jenkins-x-kubernetes/blob/4b98c965ddfc6f8a7fd1ffebf6d1757b6d9acc71/packs/maven/charts/templates/deployment.yaml#L14.

[msvticket]

Right. The headline in the istio document was misleading: "Deployments with app and version labels". But it really is the pods that should have the labels. I'll reword this story.

I think it would be useful to have the label app on the deployment as well, but that isn't istio related.

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[msvticket]

/remove-lifecycle stale

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[msvticket]

/remove-lifecycle stale

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[msvticket]

/remove-lifecycle stale

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[jenkins-x-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

[msvticket]

/remove-lifecycle rotten

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[jenkins-x-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

[msvticket]

/remove-lifecycle rotten

[tomhobson]

This is cool. Again we could put this forward to GSOC as I said in your previous issue. If there's still interest and this isn't fixed, let's do it!

[msvticket]

I still think it would be worthwhile.

It's a small fix in all the deployments defined in jx3-pipeline-catalog.