Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commons-lang-api plugin #2372

Closed
nhojpatrick opened this issue Feb 12, 2022 · 29 comments
Closed

commons-lang-api plugin #2372

nhojpatrick opened this issue Feb 12, 2022 · 29 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci

Comments

@nhojpatrick
Copy link

nhojpatrick commented Feb 12, 2022

Repository URL

https://github.com/nhojpatrick/jenkinsci_commons-lang-api-plugin

New Repository Name

commons-lang-api-plugin

Description

Creation of api-plugin, as discussed here jenkinsci/jenkins#6267 and here jenkinsci/jenkins#6270.

I want the the plugin to support the version oldest jenkins avaliable so easier for plugins to move over without themselves having to upgrade. Once every 'active' plugin updated, plan to upgrade this plugin to newer recent version.

This is my 1st attempt at creating a jenkins plugin, so probably lots needs tweaking.

GitHub users to have commit permission

nhojpatrick

Jenkins project users to have release permission

nhojpatrick

Issue tracker

GitHub issues

@nhojpatrick nhojpatrick added the hosting-request Request to host a component in jenkinsci label Feb 12, 2022
@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: Your pom.xml's <jenkins.version>(2.7.3)</jenkins.version> does not meet the minimum Jenkins version required, please update your <jenkins.version> to at least 2.277.1
  • ⛔ Required: You must add a 'groupId' in your pom.xml with the value io.jenkins.plugins.
  • ⛔ Required: The pom.xml file in the root of the origin repository is not valid
  • ⛔ Required: The parent pom version '3.2' should be at least 4.0.0 or higher
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: Any Jenkins Member/Contributor (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: Any Jenkins Member/Contributor, nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: Any Jenkins Member/Contributor
  • ⛔ Required: The 'artifactId' from the pom.xml (commons-lang3-api) is incorrect, it should be commons-lang-api ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@nhojpatrick
Copy link
Author

It does have README.md, LICENSE and pom.xml.
Could this be expected branch name issue as I've stopped using master and default is now main.

@nhojpatrick
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: Your pom.xml's <jenkins.version>(2.7.3)</jenkins.version> does not meet the minimum Jenkins version required, please update your <jenkins.version> to at least 2.277.1
  • ⛔ Required: You must add a 'groupId' in your pom.xml with the value io.jenkins.plugins.
  • ⛔ Required: The pom.xml file in the root of the origin repository is not valid
  • ⛔ Required: The parent pom version '3.2' should be at least 4.0.0 or higher
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: Any Jenkins Member/Contributor (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: Any Jenkins Member/Contributor, nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: Any Jenkins Member/Contributor

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@nhojpatrick
Copy link
Author

/hosting re-check

@nhojpatrick
Copy link
Author

issue creating 2 requests at the same time, i was pushing both local branches to the same remote repo

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: Your pom.xml's <jenkins.version>(2.7.3)</jenkins.version> does not meet the minimum Jenkins version required, please update your <jenkins.version> to at least 2.277.1
  • ⛔ Required: You must add a 'groupId' in your pom.xml with the value io.jenkins.plugins.
  • ⛔ Required: The pom.xml file in the root of the origin repository is not valid
  • ⛔ Required: The parent pom version '3.2' should be at least 4.0.0 or higher
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: Any Jenkins Member/Contributor (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: Any Jenkins Member/Contributor, nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: Any Jenkins Member/Contributor

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@nhojpatrick
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: Any Jenkins Member/Contributor (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: Any Jenkins Member/Contributor, nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: Any Jenkins Member/Contributor
  • ⛔ Required: The from the pom.xml should be io.jenkins.plugins instead of org.jenkins-ci.plugins

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The from the pom.xml should be io.jenkins.plugins instead of org.jenkins-ci.plugins

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@nhojpatrick
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@nhojpatrick
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

1 similar comment
@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@nhojpatrick
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: nhojpatrick (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@nhojpatrick
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added bot-check-complete Automated hosting checks passed and removed needs-fix labels Feb 12, 2022
@timja
Copy link
Member

timja commented Feb 12, 2022

Same issues as #2373

@nhojpatrick
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@nhojpatrick
Copy link
Author

@timja should be update like #2373

@timja
Copy link
Member

timja commented Feb 13, 2022

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@timja
Copy link
Member

timja commented Feb 13, 2022

/hosting host

@jenkins-infra-bot
Copy link
Contributor

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/commons-lang-api-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please remove your original repository (if there are no other forks) so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content:
buildPlugin()

Welcome aboard!

@timja
Copy link
Member

timja commented Feb 13, 2022

On top of what the bot said:

You'll need to update the co-ordinates in your README after group ID changed
I would suggest looking at enabling jenkins.io/doc/developer/publishing/releasing-cd along with dependabot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci
Projects
None yet
Development

No branches or pull requests

3 participants