Skip to content

Commit b221855

Browse files
authored
Merge pull request #29 from dmitrylyzo/fix-times
Fix event time comparison
2 parents 5ab8af3 + 91c62aa commit b221855

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/SubtitleOctopus.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -506,8 +506,8 @@ class SubtitleOctopus {
506506

507507
for (int i = 0; i < track->n_events; i++, cur++) {
508508
long long start = cur->Start;
509-
if (start < now) {
510-
if (start + cur->Duration >= now) {
509+
if (start <= now) {
510+
if (now < start + cur->Duration) {
511511
// there's currently an event being displayed, we should render it
512512
closest = now;
513513
break;

src/subtitles-octopus.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ var SubtitlesOctopus = function (options) {
268268
var retainedItems = [];
269269
for (var i = 0, len = self.renderedItems.length; i < len; i++) {
270270
var item = self.renderedItems[i];
271-
if (item.emptyFinish < 0 || item.emptyFinish >= currentTime) {
271+
if (item.emptyFinish < 0 || currentTime < item.emptyFinish) {
272272
// item is not yet finished, retain it
273273
retainedItems.push(item);
274274
}
@@ -348,7 +348,7 @@ var SubtitlesOctopus = function (options) {
348348
}
349349

350350
function _renderSubtitleEvent(event, currentTime) {
351-
var eventOver = event.eventFinish < currentTime;
351+
var eventOver = event.eventFinish <= currentTime;
352352
if (self.oneshotState.eventStart == event.eventStart && self.oneshotState.eventOver == eventOver) return;
353353
self.oneshotState.eventStart = event.eventStart;
354354
self.oneshotState.eventOver = eventOver;
@@ -433,7 +433,7 @@ var SubtitlesOctopus = function (options) {
433433
var size = 0;
434434
for (var i = 0; i < self.renderedItems.length; i++) {
435435
var item = self.renderedItems[i];
436-
if (item.emptyFinish < 0 || item.emptyFinish >= stopTime) break;
436+
if (item.emptyFinish < 0 || stopTime < item.emptyFinish) break;
437437
size += item.size;
438438
if (size >= sizeLimit) break;
439439
newCache.push(item);

0 commit comments

Comments
 (0)