Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update asset host URL #90

Merged
merged 1 commit into from
Feb 13, 2019
Merged

fix: update asset host URL #90

merged 1 commit into from
Feb 13, 2019

Conversation

jekyllbot
Copy link
Contributor

@jekyllbot jekyllbot commented Feb 13, 2019 •
edited by DirtyF
Loading

Fix #89

@DirtyF DirtyF changed the title Update jemoji.rb Update asset host URL Feb 13, 2019
@DirtyF DirtyF added the fix label Feb 13, 2019
@DirtyF DirtyF changed the title Update asset host URL WIP: update asset host URL Feb 13, 2019
@DirtyF DirtyF changed the title WIP: update asset host URL fix: update asset host URL Feb 13, 2019
ashmaroli
ashmaroli approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ashmaroli
Copy link
Member

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 76e3052 into master Feb 13, 2019
@jekyllbot jekyllbot added the bug label Feb 13, 2019
@jekyllbot jekyllbot deleted the pull/assets-host-url branch February 13, 2019 19:06
jekyllbot added a commit that referenced this pull request Feb 13, 2019
@jekyllbot
Update history to reflect merge of #90 [ci skip]
4992bd6
@ashmaroli
Copy link
Member

Thank you @DirtyF 😃

@jekyll jekyll locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with displaying emojis, wrong url
3 participants
@jekyllbot @ashmaroli @DirtyF