Skip to content

Commit b810088

Browse files
committed
WIP: make changes based on feedback
1 parent 4f471fc commit b810088

File tree

4 files changed

+18
-28
lines changed

4 files changed

+18
-28
lines changed

scripts/angular.js/untag-release.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#!/bin/bash
22

3-
# Tags a release
4-
# so that travis can do the actual release.
3+
# Untags a release.
54

65
echo "###################################"
76
echo "## Untag angular.js for a release #"
@@ -29,12 +28,12 @@ function init {
2928
}
3029

3130
function prepare() {
32-
git tag -d "$TAG_NAME"
31+
#no-op since publish does everything
3332
}
3433

3534
function publish() {
3635
# push the tag deletion to github
37-
git push origin ":refs/tags/$TAG_NAME"
36+
git push origin ":$TAG_NAME"
3837
}
3938

4039
source $(dirname $0)/../utils.inc

scripts/bower/unpublish.sh

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22

3-
# Script for updating the Angular bower repos from current local build.
3+
# Script for removing tags from the Angular bower repos
44

55
echo "#################################"
66
echo "#### Untag bower ################"
@@ -29,9 +29,6 @@ function init {
2929
)
3030
}
3131

32-
33-
34-
3532
function prepare {
3633
#
3734
# clone repos
@@ -44,15 +41,16 @@ function prepare {
4441

4542
#
4643
# update bower.json
47-
# tag each repo
44+
# delete tag in each repo
4845
#
4946
for repo in "${REPOS[@]}"
5047
do
51-
echo "-- Removing $NEW_VERSION tag from bower-$repo"
48+
echo "-- Creating dummy git repo for bower-$repo with origin remote"
49+
mkdir $TMP_DIR/bower-$repo
5250
cd $TMP_DIR/bower-$repo
51+
git init
52+
git remote add origin git@github.com:angular/bower-$repo.git
5353

54-
echo "-- Deleting tag v$VERSION_NUMBER in bower-$repo"
55-
git tag -d v$VERSION_NUMBER
5654
cd $SCRIPT_DIR
5755
done
5856
}
@@ -62,7 +60,7 @@ function publish {
6260
do
6361
echo "-- Pushing bower-$repo"
6462
cd $TMP_DIR/bower-$repo
65-
git push origin v$NEW_VERSION
63+
git push origin :v$VERSION_NUMBER
6664
cd $SCRIPT_DIR
6765
done
6866
}

scripts/code.angularjs.org/unpublish.sh

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
#!/bin/bash
22

3-
# Script for updating code.angularjs.org repo from current local build.
3+
# Script for removing specified release dir from code.angularjs.org.
44

5-
echo "#################################"
6-
echo "## Update code.angular.js.org ###"
7-
echo "#################################"
5+
echo "################################################"
6+
echo "## Remove a version from code.angular.js.org ###"
7+
echo "################################################"
88

99
ARG_DEFS=(
1010
"--action=(prepare|publish)"
@@ -22,27 +22,24 @@ function prepare {
2222
git clone git@github.com:angular/code.angularjs.org.git $REPO_DIR
2323

2424
#
25-
# copy the files from the build
25+
# Remove the files from the repo
2626
#
2727
echo "-- Removing $VERSION_NUMBER from code.angularjs.org"
2828
cd $REPO_DIR
2929
git rm -r $VERSION_NUMBER
3030

31-
#
32-
# commit
33-
#
34-
echo "-- Committing code.angularjs.org"
31+
echo "-- Committing removal to code.angularjs.org"
3532
git commit -m "removing v$VERSION_NUMBER"
3633
}
3734

3835
function _update_code() {
3936
cd $REPO_DIR
4037

41-
echo "-- Pushing code.angularjs.org"
38+
echo "-- Pushing code.angularjs.org to github"
4239
git push origin master
4340

4441

45-
echo "-- Refreshing code.angularjs.org: backend=$backend"
42+
echo "-- Propagating update to server code.angularjs.org"
4643
curl https://code.angularjs.org/gitFetchSite.php
4744

4845
}

scripts/jenkins/undo-release.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,4 @@ function run {
4242
phase publish
4343
}
4444

45-
echo $VERSION_NUMBER
46-
# Will need to change the angular.js CHANGELOG.md manually
47-
git tag -d $VERSION_NUMBER
48-
4945
source $(dirname $0)/../utils.inc

0 commit comments

Comments
 (0)