Update test coverage and error handlings

Author: jedymatt

src/sqlalchemyseed/class_registry.py

@@ -26,13 +26,14 @@
 from sqlalchemy.exc import NoInspectionAvailable
 from inspect import isclass
 from sqlalchemy import inspect
+from . import errors
 
 
 def parse_class_path(class_path: str):
     try:
         module_name, class_name = class_path.rsplit('.', 1)
     except ValueError:
-        raise ValueError('Invalid module or class input format.')
+        raise errors.ParseError('Invalid module or class input format.')
 
     # if class_name not in classes:
     class_ = getattr(importlib.import_module(module_name), class_name)
@@ -67,7 +68,7 @@ def __getitem__(self, class_path: str):
 
     @property
     def classes(self):
-        return self._classes
+        return tuple(self._classes)
 
     def clear(self):
         self._classes.clear()

src/sqlalchemyseed/errors.py

@@ -26,3 +26,7 @@ class EmptyDataError(Exception):
 class InvalidKeyError(Exception):
     """Raised when an invalid key is invoked"""
     pass
+
+class ParseError(Exception):
+    """Raised when parsing string fails"""
+    pass

src/sqlalchemyseed/loader.py

@@ -83,7 +83,3 @@ def load_entities_from_csv(csv_filepath: str, model) -> dict:
     validator.SchemaValidator.validate(entities)
 
     return entities
-
-
-if __name__ == '__main__':
-    load_entities_from_yaml('tests/res/data.yaml')

tests/test_class_registry.py

@@ -1,4 +1,5 @@
 import unittest
+from src.sqlalchemyseed import errors
 
 from src.sqlalchemyseed.class_registry import ClassRegistry
 
@@ -13,3 +14,15 @@ def test_register_class(self):
         class_registry.register_class('tests.models.Company')
         from tests.models import Company
         self.assertIs(class_registry['tests.models.Company'], Company)
+
+    def test_get_classes(self):
+        class_registry = ClassRegistry()
+        class_registry.register_class('tests.models.Company')
+        self.assertIsNotNone(class_registry.classes)
+
+    def test_register_invalid_string_format(self):
+        class_registry = ClassRegistry()
+        self.assertRaises(
+            errors.ParseError,
+            lambda: class_registry.register_class('RandomString')
+        )

tests/test_loader.py

@@ -10,10 +10,24 @@ def test_load_entities_from_json(self):
         entities = load_entities_from_json('tests/res/data.json')
         self.assertEqual(len(entities), 6)
 
+    def test_load_entities_from_json_file_not_found(self):
+        self.assertRaises(FileNotFoundError,
+                          lambda: load_entities_from_json('tests/res/non-existent-file'))
+
     def test_load_entities_from_yaml(self):
         entities = load_entities_from_yaml('tests/res/data.yml')
         self.assertEqual(len(entities), 2)
 
-    def test_load_entities_from_csv(self):
-        entities = load_entities_from_csv('tests/res/companies.csv', 'tests.models.Company')
+    def test_load_entities_from_yaml_file_not_found(self):
+        self.assertRaises(FileNotFoundError,
+                          lambda: load_entities_from_yaml('tests/res/non-existent-file'))
+
+    def test_load_entities_from_csv_input_class(self):
+        from tests.models import Company
+        entities = load_entities_from_csv(
+            'tests/res/companies.csv', Company)
         self.assertEqual(len(entities['data']), 3)
+
+    def test_load_entities_from_csv_input_model_string(self):
+        self.assertIsNotNone(load_entities_from_csv(
+            'tests/res/companies.csv', "tests.models.Company"))