Directly build to core-js without grunt-cli #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! I will test this tomorrow |
| @@ -34,7 +34,7 @@ var loadClientBundleLink = path.join(dirs.meteor, 'client/loadClientBundle.html' | |||
|
|
|||
| var requireServerBundleJs = path.join(dirs.meteor, 'server/require.server.bundle.js'); | |||
|
|
|||
| require('./core-js-custom-build'); | |||
| exec('node core-js-custom-build.js'); | |||
|
|
|||
There was a problem hiding this comment.
does require not work here for some reason? I'd rather use require if possible because shelljs claims that synchronous exec can have performance problems for long-running processes. Probably not a big deal here but just makes me want to avoid synchronous exec if possible
There was a problem hiding this comment.
Ah right, makes sense. Yeah I think exec is better than going to the trouble of passing a callback from the main scripts
jedwards1211
added a commit
that referenced
this pull request
Oct 19, 2015
Directly build to core-js without grunt-cli
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed core-js build process from external packages and merge it from core-js repo. (zloirock/core-js#120)
It released today (https://github.com/zloirock/core-js/releases/tag/v1.2.2) then I wrote custom build code. (https://github.com/zloirock/core-js#custom-build)
remove dependencies grunt and grunt-cli.
I hope this PR will be more easily handle core-js and solve #102 issue.