[HSDK-2] refactor

Author: ivancalle-sipay

src/paymethods/Card.php

@@ -7,7 +7,7 @@ class Card implements Paymethod
     private $year;
     private $month;
 
-    public function __construct($card_number, $year, $month)
+    public function __construct(string $card_number, int $year, int $month)
     {
         $this->set_card_number($card_number);
         $this->set_expiration_date($year, $month);
@@ -18,12 +18,8 @@ public function get_card_number()
         return $this->card_number;
     }
 
-    public function set_card_number($card_number)
+    public function set_card_number(string $card_number)
     {
-        if (gettype($card_number) != "string") {
-            throw new \Exception('$card_number must be a string.');
-        }
-
         if(!preg_match("/^[0-9]{14,19}$/", $card_number)) {
             throw new \Exception('$card_number don\'t match with pattern.');
         }
@@ -41,22 +37,14 @@ public function get_month()
         return $this->month;
     }
 
-    public function set_expiration_date($year, $month)
+    public function set_expiration_date(int $year, int $month)
     {
-        if (gettype($year) != "integer") {
-            throw new \Exception('$year must be a string.');
-        }
-
         if($year < 1000 or $year >9999) {
             throw new \Exception('$year doesn\'t have a correct value.');
         }
 
         $this->year = $year;
 
-        if (gettype($month) != "integer") {
-            throw new \Exception('$month must be a string.');
-        }
-
         if($month < 1 or $month > 12) {
             throw new \Exception('$month doesn\'t have a correct value.');
         }

src/paymethods/FastPay.php

@@ -3,17 +3,13 @@
 
 class FastPay implements Paymethod
 {
-    public function __construct($token)
+    public function __construct(string $token)
     {
         $this->set_token($token);
     }
 
-    public function set_token($token)
+    public function set_token(string $token)
     {
-        if (gettype($token) != "string") {
-            throw new \Exception('$token must be a string.');
-        }
-
         if(!preg_match("/^[0-9a-fA-F]{32}$/", $token)) {
             throw new \Exception('$token don\'t match with pattern.');
         }

src/paymethods/StoredCard.php

@@ -3,17 +3,13 @@
 
 class StoredCard implements Paymethod
 {
-    public function __construct($token)
+    public function __construct(string $token)
     {
         $this->set_token($token);
     }
 
-    public function set_token($token)
+    public function set_token(string $token)
     {
-        if (gettype($token) != "string") {
-            throw new \Exception('$token must be a string.');
-        }
-
         if(!preg_match("/^[\w-]{6,128}$/", $token)) {
             throw new \Exception('$token don\'t match with pattern.');
         }