Pk5/fix integration tests for release #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logic looks good to me. As discussed, check with Dave as to whether we should merge this now or not |
pjw711
reviewed
May 16, 2024
| artifact_manifest_name=config.acrManifestName, | ||
| ).as_dict() | ||
| break | ||
| except ServiceResponseError as error: |
There was a problem hiding this comment.
So I think if you hit an exception that isn't a ServiceResponseError the code will just exit. Is that right? If not, there's an infinite loop.
There was a problem hiding this comment.
It is just going to fail with another exception but we are not going to catch it
| # This retry logic is to handle the ServiceResponseError that is hit in the integration tests. | ||
| # This error is not hit when running the cli normally because the CLI framework automatically retries, | ||
| # the testing framework does not support automatic retries. | ||
| while retries < 2: |
There was a problem hiding this comment.
Couple of questions:
- Are automatic retries going to race/conflict with these ones? I'm not sure what would happen if they did - maybe it's fine.
- Why aren't these retries in the test code if it's a limitation in the test framework?
There was a problem hiding this comment.
- The automatic retires should not race with this one because the ServiceResponseError is only raised when running in a test.
- I have discussed with the rest of the team about fixing in the testing code and we decided that it would be complicated to figure out (if even possible) so we should just fix it in the main code and chase the CLI team about this problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list_credentialmethod we do not retry on failure. When running the CLI normally (outside of the testing framework), the retries happen automatically which means that the command would succeed when running outside of the testing framework. This seems like an external issue but can be fixed by adding a short while loop to retry thelist_credentialmethod