Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Integration Tests from MultiNF Bug Fix #191

Merged
merged 4 commits into from
May 17, 2024

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented May 14, 2024


The bug fix means we use the nf name not nsd name, so this impacts our build output folder.
This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jordlay jordlay requested a review from sunnycarter as a code owner May 14, 2024 11:39
@patrykkulik-microsoft
Copy link
Collaborator

lgtm

@jordlay jordlay merged commit cfbdb26 into 2.0.0b2-release May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants