Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding build command for site #189

Merged
merged 8 commits into from
May 14, 2024
Merged

Adding build command for site #189

merged 8 commits into from
May 14, 2024

Conversation

rkaraddi
Copy link
Collaborator

@rkaraddi rkaraddi commented May 9, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

azdev test aosm - all my test cases are passing
azdev style aosm passed
azdev linter aosm passed

Testing by deploying to azure portal

SNS build command

az aosm sns build --config-file sns-input.jsonc

  • Initially no output folder
    no output folder
  • Running the command
    creating build folder
  • output folder created
    Screenshot 2024-05-13 171529
  • Retrying when the folder is present
    build folder already exists
  • Deploy input folder with nfvi populated from NSDV
    deploy folder
  • Adding the custom location
    adding the cl
  • All parameters file
    all parameter values

SNS deploy command

az aosm sns deploy --build-output-folder sns-cli-output

  • Command

Screenshot 2024-05-13 172032

  • Azure portal deployment
    deploying site
  • Site created with nfvi and respective custom location
    site created
  • Trying to create site in a different RG from where the publisher is present

Screenshot 2024-05-13 172150

  • The RG is created and the site gets created in the new RG

new rg site created

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@rkaraddi rkaraddi requested a review from sunnycarter as a code owner May 9, 2024 23:47
@rkaraddi rkaraddi merged commit d016e20 into 2.0.0b2-release May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants