Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priyavij/sitework #188

Merged
merged 8 commits into from
May 10, 2024
Merged

Priyavij/sitework #188

merged 8 commits into from
May 10, 2024

Conversation

priyavj08
Copy link
Collaborator

@priyavj08 priyavj08 commented May 8, 2024


This is only for generating input config for SNS creation, implements generate-config and dumps all the input parameters in all_deployment_parameter.json using build_all_parameters method.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • (priyavij) priyavij@priyavij:~/validatearmtemplate/azure-cli-extensions$ azdev style aosm

===============
| Style Check |

Extensions: aosm

Running pylint on extensions...
Pylint: PASSED

Running flake8 on extensions...
Flake8: PASSED

  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@priyavj08 priyavj08 merged commit f943f99 into 2.0.0b2-release May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants