check if resource types used in the VNF ARM template are valid #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordlay
reviewed
May 1, 2024
| for resource_type in arm_resource_types: | ||
| resource_type_prefix = resource_type.split('/')[0] if '/' in resource_type else resource_type | ||
| if resource_type_prefix not in VALID_VNF_TEMPLATE_RESOURCE_TYPES: | ||
| raise InvalidARMResourceType( |
There was a problem hiding this comment.
If you raise a CLI error isntead, you won't get the trace printed to the user. I just tested it with InvalidTemplateError but there may be a better one. To use these errirs import like this:
from azure.cli.core.azclierror import InvalidTemplateError
There was a problem hiding this comment.
For reference, the errors available for use in the CLI are all declared here:
https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/azclierror.py
(Or of course you can click through to the azure.cli.core.azclierror module in VS Code to find them too.)
|
Looks good to me. One comment on the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.tested with invalid resource type in arm template by running "az aosm nfd build --definition-type vnf-nexus --config-file /home/priyavij/testbug/input.jsonc"