2.0.0b2 release #185
Open
2.0.0b2 release #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix: Change 'deploymentParameters' to 'deployParameters' * Refactoring including: - Remove minor inconsistencies between related methods - Use named parameters in method calls to improve readability - Rename variables and methods to be more descriptive/accurate - Improve some exception messages - Make log messages clearer - Improve code comments - Improve type handling --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com>
* Fix: Change 'deploymentParameters' to 'deployParameters' * Refactoring including: - Remove minor inconsistencies between related methods - Use named parameters in method calls to improve readability - Rename variables and methods to be more descriptive/accurate - Improve some exception messages - Make log messages clearer - Improve code comments - Improve type handling * Comment out _find_image_pull_secrets_values_paths(). * Add expose_all function for NFDs. Includes extensive renaming of variables and methods, new code comments and docstrings. * Add expose_all_params to nfd-input.jsonc and plumb through. * Fix linting + tests for release (#171) * removed delete helptext and reran tests live * fixed linting --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * added license headers to fix release jobs (#172) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Markups * Add Webhook (#159) * initial attempt at adding roleOverride * add comma * removed comma as breaks single nf application * remove prints * fixed linting + updated history * fixed bug in nfd processor for vnfs; updated nsd tests * fixed lives tests * markups * markups2 --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * fixed line too long * markups including removing multiple instances * fixed all unit tests based on new param (expose_all), removed param (multiple_instances), refactoring of deploymentParameters to deployParams, and removal of using values.schema.json * ran live tests + removed dependsOn * added getting defaults from arm template + added special logic for when defaults are rg().location * fixed tests + fixed styling * ran live tests --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Patryk Kulik <patrykkulik@microsoft.com>
Improve code clarity by putting all .tgz unpack code in the same if/else branch. Bonus: we also avoid creating a tempdir if we don't need to.
* refactor from day of learning; needs testing * added jsonbuilder import + fixed style --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com>
Adding a validation to check if base resources are already deployed.
* changes to validate arm resource type * added change details in history * fixed exception type --------- Co-authored-by: Priya Vijayaraghavan <priyavij@microsoft.com>
* changed artifact name and processor name ti nf name from nsd * updated history --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com>
* adding SNS handler and input config * adding SNS handler and input config * fixed style error * new recording of vnf test * fixed validations * fixed UT and deploy_all_parameter * fixed history --------- Co-authored-by: Priya Vijayaraghavan <priyavij@microsoft.com>
* Bump jinja2 to 3.1.4. * Remove azure-storage-blob from dependencies.
Adding build and deploy command for site.
Resolving style error
* fixed integration tests * ran live tests --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.