Adding a validation to check if base resources are already deployed. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated changelog * markups --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com>
- Add examples - Minor rewording - Ensure all commands are preview
jordlay
reviewed
Apr 25, 2024
src/aosm/azext_aosm/definition_folder/reader/bicep_definition.py
Outdated
Show resolved
Hide resolved
jordlay
reviewed
Apr 25, 2024
src/aosm/azext_aosm/definition_folder/reader/bicep_definition.py
Outdated
Show resolved
Hide resolved
|
I think its a code smell that we are have so many if statement for instance checking, however, that's not on you to fix. We also do it in the artifact manifest exist code. You may need to run your azdev commands again now that I've asked you to change the target branch to b2 release. Could you also add to the PR if you have done any manual testing? Like successfully publishing an nfdv without skipping base and with? Looks good! |
|
You should also update the history.RST under the b2 release with your change |
jordlay
reviewed
Apr 25, 2024
|
Rakshita and I have chatted, we need to make a few changes before this is ready. Will rereview after that :) |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)User story for this change
https://dev.azure.com/msazuredev/AzureForOperators/_workitems/edit/1161413
Ran the tests locally:
Ran the style test locally:
Ran the linter test locally:
Testing my deploying on portal
NFDV
When NFD group(or any base resource) is not present the base resources are redeployed
When all base resources are present then only NFDV get deployed
There is an improvement of ~ 4 mins in command runtime
NSDV
When NSD Group(or any base resource) is not present then all base resources are deployed
When all base resources are present then only CGS and NSDV get deployed
There is an improvement of ~ 4 mins in command runtime
For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.