Simplified logic for rendering plugins in the tota11y toolbar #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2015
Closed
Merged
jdan
added a commit
that referenced
this pull request
Jul 25, 2015
Simplified logic for rendering plugins in the tota11y toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @MichelleTodd
||@rileyjshaw,Previously, tota11y used a strange mechanism for mounting plugins to the toolbar and switching between them on user interaction. After the JSX fun was added in #42, I wanted to try to make plugin rendering more explicit.
This changeset moves the logic for activating/deactivating plugins from the plugins themselves and into the Toolbar module. This allowed me to remove the weird event listener mechanism and swap it for a more straightforward
handlePluginClickmethod.