-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme support #94
base: main
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jdan/98css/CPkQFeZBAoEqyMCVviYqU8amPaGv |
3c4b77d
to
29147e1
Compare
In light of #107, I've updated this pull request to the tip of |
29147e1
to
6c0cbe2
Compare
Support the full range of configurable colors in a Windows Classic theme. The colors are configured using CSS variables named after the corresponding Windows theme file property converted from PascalCase to kebab-case. Colors are given in rgb format to make it easier to convert and recognize values from a Windows theme file. The old variables are kept for backwards compatibility and are mapped accordingly. However, the old `--button-face`, which maps to `--button-light`, has not been mapped because of a name conflict with the new `--button-face`; this is a breaking change.
Remove the radio width from the calculation for the radio dot top value. I'm not sure why this works, but it does. Also remove redundant precalc variables. Nested calc calls are reduced to a single one automatically.
The computed asset, 98.css, precomputes the values that uses CSS variables. The non-computed asset, 98-full.css, preserves the variables and uses the computed values as fallbacks for browsers without support for custom properties.
6c0cbe2
to
86b6f52
Compare
Assuming it works with vars, it looks like https://www.npmjs.com/package/postcss-inline-svg can apply transforms to the SVGs as they are being bundled/inlined. So this could be used to compile themes (but not for theming at runtime) |
Reopening #39 after the
master
tomain
rename closed it. See the original PR for a description and test themes.Closes #33