Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing projectId in return type of api.Search.all('commits' ... ) #3568

Closed
2 tasks done
aljorhythm opened this issue Apr 11, 2024 · 1 comment · Fixed by #3573
Closed
2 tasks done

missing projectId in return type of api.Search.all('commits' ... ) #3568

aljorhythm opened this issue Apr 11, 2024 · 1 comment · Fixed by #3573
Labels
released This issue/pull request has been released.

Comments

@aljorhythm
Copy link

aljorhythm commented Apr 11, 2024 •
edited
Loading

Description

projectId is present in searches that are scoped to 'commits' in gitlab API https://docs.gitlab.com/ee/api/search.html#scope-commits. This is not refected in the return type of api.Search.all('commits', ...)

Steps to reproduce

image

Expected behaviour

Actual behaviour

Type not found

Possible fixes

modify Search.ts
image

Checklist

  • I have checked that this is not a duplicate issue.
  • I have read the documentation.
@jdalrymple jdalrymple mentioned this issue Apr 11, 2024
Merged
@jdalrymple
Copy link
Owner

🚀 Issue was released in 40.0.3 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing search commit types jdalrymple/gitbeaker
2 participants
@aljorhythm @jdalrymple