We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description
Missing line_range field in the position schema for DiscussionNotePositionTextSchema.
line_range
position
Steps to reproduce
Expected behaviour
Actual behaviour
Possible fixes
Checklist
The text was updated successfully, but these errors were encountered:
This is what I came up with based on what I see in the Webhook event for the DiffNote:
export interface DiscussionNotePositionTextLineSchema { line_code?: string; type?: 'new' | 'old'; old_line?: number; new_line?: number; } export interface DiscussionNotePositionLineRangeSchema { start?: DiscussionNotePositionTextLineSchema; end?: DiscussionNotePositionTextLineSchema; } export type DiscussionNotePositionTextSchema = DiscussionNotePositionBaseSchema & { position_type: 'text'; new_line?: string; old_line?: string; line_range?: DiscussionNotePositionLineRangeSchema; };
Sorry, something went wrong.
🚀 Issue was released in 40.0.3 🚀
40.0.3
Successfully merging a pull request may close this issue.
Description
Missing
line_range
field in theposition
schema for DiscussionNotePositionTextSchema.Steps to reproduce
Expected behaviour
Actual behaviour
Possible fixes
Checklist
The text was updated successfully, but these errors were encountered: