Skip to content

Add call method to BaseRetying #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Dec 16, 2020
Merged

Add call method to BaseRetying #267

mergify merged 1 commit into from
Dec 16, 2020

Conversation

@hartungstenio
Copy link
Contributor

@hartungstenio hartungstenio commented Dec 16, 2020 •
edited
Loading

#253 made Retrying and AsyncRetrying (and BaseRetrying itself) callable, but it broke compatibility of AsyncRetrying by removing the legacy call method.

This moves the deprecated call method to the base class to regain compatibility since no major versions were released

@hartungstenio hartungstenio marked this pull request as ready for review December 16, 2020 18:59
@mergify mergify bot merged commit 98f7da7 into jd:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jd jd jd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hartungstenio @jd