SIP-109 Additional update access control as batch (Synthetixio#1072)

Author: justin j. moses

contracts/SystemStatus.sol

@@ -27,13 +27,7 @@ contract SystemStatus is Owned, ISystemStatus {
 
     mapping(bytes32 => Suspension) public synthSuspension;
 
-    constructor(address _owner) public Owned(_owner) {
-        _internalUpdateAccessControl(SECTION_SYSTEM, _owner, true, true);
-        _internalUpdateAccessControl(SECTION_ISSUANCE, _owner, true, true);
-        _internalUpdateAccessControl(SECTION_EXCHANGE, _owner, true, true);
-        _internalUpdateAccessControl(SECTION_SYNTH_EXCHANGE, _owner, true, true);
-        _internalUpdateAccessControl(SECTION_SYNTH, _owner, true, true);
-    }
+    constructor(address _owner) public Owned(_owner) {}
 
     /* ========== VIEWS ========== */
     function requireSystemActive() external view {
@@ -133,6 +127,23 @@ contract SystemStatus is Owned, ISystemStatus {
         _internalUpdateAccessControl(section, account, canSuspend, canResume);
     }
 
+    function updateAccessControls(
+        bytes32[] calldata sections,
+        address[] calldata accounts,
+        bool[] calldata canSuspends,
+        bool[] calldata canResumes
+    ) external onlyOwner {
+        require(
+            sections.length == accounts.length &&
+                accounts.length == canSuspends.length &&
+                canSuspends.length == canResumes.length,
+            "Input array lengths must match"
+        );
+        for (uint i = 0; i < sections.length; i++) {
+            _internalUpdateAccessControl(sections[i], accounts[i], canSuspends[i], canResumes[i]);
+        }
+    }
+
     function suspendSystem(uint256 reason) external {
         _requireAccessToSuspend(SECTION_SYSTEM);
         systemSuspension.suspended = true;

publish/src/commands/deploy.js

@@ -534,6 +534,24 @@ const deploy = async ({
 		args: [account],
 	});
 
+	if (network !== 'mainnet' && systemStatus) {
+		// On testnet, give the deployer the rights to update status
+		await runStep({
+			contract: 'SystemStatus',
+			target: systemStatus,
+			read: 'accessControl',
+			readArg: [toBytes32('System'), account],
+			expected: ({ canSuspend } = {}) => canSuspend,
+			write: 'updateAccessControls',
+			writeArg: [
+				['System', 'Issuance', 'Exchange', 'SynthExchange', 'Synth'].map(toBytes32),
+				[account, account, account, account, account],
+				[true, true, true, true, true],
+				[true, true, true, true, true],
+			],
+		});
+	}
+
 	const exchangeRates = await deployer.deployContract({
 		name: 'ExchangeRates',
 		source: useOvm ? 'ExchangeRatesWithoutInvPricing' : 'ExchangeRates',