Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Admin rights required to update 3P for notepad++ version 7.6.1 to 7.6.2 #249

Closed
gurikbal opened this issue Jan 26, 2019 · 4 comments
Closed
Labels
Milestone

Comments

@gurikbal
Copy link

gurikbal commented Jan 26, 2019

capture-20190125-202057
capture-20190125-202241
Description of the Issue

after auto update 3p plugin give error messeges

i accept there plugin directory are changed in Notepad++ v7.6.1 and will be next version changes too

Debug Information
Notepad++ v7.6.1 (32-bit)
Build time : Dec 12 2018 - 01:24:22
Path : C:\Program Files\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS : Windows 7 (32-bit)
Plugins : 3P.dll Console_output.dll DSpellCheck.dll mimeTools.dll NppConsole.dll NppConverter.dll NppFTP.dll NppToolBucket.dll PythonScript.dll Remove_dup_lines.dll

@jcaillon
Copy link
Owner

jcaillon commented Feb 1, 2019

Hello, is it possible that you had several instances of notepad++ started?
Did you have a popup asking you to run 3pUpdater with admin rights when you closed notepad++?

Repository owner deleted a comment from gurikbal Feb 5, 2019
@jcaillon
Copy link
Owner

jcaillon commented Feb 5, 2019

Sorry, I can't open a random 20Mb .pptx from the internet x)
If you are not going to use github comments, please use a safer file format (.pdf?).

@gurikbal
Copy link
Author

gurikbal commented Feb 6, 2019

@jcaillon
Copy link
Owner

jcaillon commented Feb 6, 2019

Alright! Thank you for the video, it helped me understand the issue :)

I just reproduced with notepad++ v7.6.1 (it works fine for the latest version which is v7.6.3).

There has been a lot of changes regarding the location of plugins in v7.6.x:

  • in v7.6.0, plugins were moved from /plugins/PLUGINNAME.dll to /plugins/PLUGINNAME/PLUGINNAME.dll
  • in v7.6.1, the base plugins folder was moved from %LOCALAPPDATA% to %PROGRAMDATA%
  • in v7.6.3, the base plugins folder is now always %ProgramFiles%\Notepad++\plugins\ (for non portable installation)

The problem you encounter is only for v7.6.1 because the 3P.dll is copied with admin rights in %PROGRAMDATA% and I do not correctly detect the need for admin rights to override the file during a 3P update...

The easiest fix is to reinstall v7.6.3. I'll try to handle this particular case, but since it only happens in v7.6.1 and v7.6.2, it should not impact a lot of users.

@jcaillon jcaillon added this to the v1.8.4 milestone Feb 6, 2019
@jcaillon jcaillon added the bug label Feb 6, 2019
@jcaillon jcaillon changed the title error messeges ! Admin rights required to update 3P for notepad++ version 7.6.1 to 7.6.2 Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants