Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Enhancement for NormedVariables #184

Open
odin-vii opened this issue Oct 27, 2017 · 6 comments
Open

Enhancement for NormedVariables #184

odin-vii opened this issue Oct 27, 2017 · 6 comments
Milestone

Comments

@odin-vii
Copy link

Description of the Issue

Update list of NormedVariables prefixes.

Expected Behavior

I used to update the list in the user defined language. Our company uses dashes (-) instead of underscores (_). Either updating the list permanently or allowing modification some how in the plugin would be nice.

@odin-vii odin-vii changed the title Enhancement Enhancement for NormedVariables Oct 27, 2017
@jcaillon
Copy link
Owner

Hello,

Okay sure, i can add an option, at least momentarily. I think ill add dynamic color highlighting on variables later so thi soption should become irrelevant. However, you can not trust the colors to know if you named correctly your variable since it colors w/e its type is (integer call ll_ would be colored but the prefix is wrong). It's better to create a prolint rule to check this. And to be honest, I think this kind of naming convention is obsolete when you use an IDE than can analyse the type of a variable -> but yeah, company/client policies -_-"

++

@jcaillon jcaillon added this to the v1.7.7 milestone Oct 29, 2017
@odin-vii
Copy link
Author

Great. Thanks.

@jcaillon jcaillon modified the milestones: v1.7.7, v1.8.0 Jan 9, 2018
@jcaillon
Copy link
Owner

image

@odin-vii
Copy link
Author

Thanks for the update. I pulled down the latest version and found a 'bug' related to this. The parser is still expecting an _ in the variable. I'm not 100% sure this is the issue, but I think the issue is on Line 111 of /3PA/MainFeatures/SyntaxHighlighting/SyntaxHighlightVisitor.cs:

var pos = tok.Value.IndexOf("_", StringComparison.CurrentCultureIgnoreCase);

@jcaillon
Copy link
Owner

Ahm this is awkward... Yes you are totally right, I will correct this.

@jcaillon jcaillon reopened this Feb 19, 2018
@odin-vii
Copy link
Author

No worries... thanks for all the time you put into this great plugin. Me and my team thought we would never find a descent tool to use with our progress code base.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants