Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose drop_duplicate_grid_labels in the public API #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose drop_duplicate_grid_labels in the public API #356

wants to merge 1 commit into from

Conversation

jbusecke
Copy link
Owner

  • Write a test that the combine func never returns duplicate match_attrs. Before this fix keys from drop_duplicate_grid_labels would have variable_id in there twice!
  • Closes #xxxx
  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@jbusecke
Expose drop_duplicate_grid_labels in the public API
f717173 
- [ ] Write a test that the combine func never returns duplicate match_attrs. Before this fix keys from drop_duplicate_grid_labels would have variable_id in there twice!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jbusecke