Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations and device_state to use lower key text #38

Merged
merged 7 commits into from
Jul 16, 2023

Conversation

jbouwh
Copy link
Owner

@jbouwh jbouwh commented Jul 16, 2023

Translations in Home Assistant require a lower case key.

BREAKING CHANGE:
This PR also changes to the untranslated state values of the device_state sensor.
Users that have automations based on the device state should update them to expect lower case states.

@jbouwh
Copy link
Owner Author

jbouwh commented Jul 16, 2023

Coverage

Coverage Report
FileStmtsMissCover
custom_components
   __init__.py00100%
custom_components/elro_connects
   __init__.py350100%
   config_flow.py920100%
   const.py50100%
   device.py1180100%
   helpers.py350100%
   sensor.py370100%
   siren.py430100%
TOTAL3650100%

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 1.541s ⏱️

@jbouwh jbouwh merged commit 1b61ac6 into main Jul 16, 2023
2 checks passed
@jbouwh jbouwh deleted the fix-translation-keys branch July 16, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant