Fix issue #84 "Reset fails in MSSQL when using temporal tables and reserved words for table names" #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbogard
requested changes
Oct 17, 2021
Respawn/SqlServerDbAdapter.cs
Outdated
| foreach (var table in tablesToTurnOnSystemVersioning) | ||
| { | ||
| builder.Append($"alter table {table.Schema}.{table.Name} set (SYSTEM_VERSIONING = ON (HISTORY_TABLE = {table.HistoryTableSchema}.{table.HistoryTableName}));\r\n"); | ||
| builder.Append($"alter table \"{table.Schema}\".\"{table.Name}\" set (SYSTEM_VERSIONING = ON (HISTORY_TABLE = {table.HistoryTableSchema}.{table.HistoryTableName}));\r\n"); |
Owner
There was a problem hiding this comment.
You can use the QuoteCharacter constant here to make this a bit more consistent.
Fixes sql errors due to using a reserved word (e.g. user, group) as a table name.
vmarko-sowalabs
force-pushed
the
master
branch
from
1656cdf to
b6870f9
Compare
jbogard
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sql errors due to using a reserved word (e.g. user, group) as a table name.