Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ne5Gc usage data #1

Open
Bernadetadad opened this issue Aug 18, 2024 · 2 comments
Open

Add Ne5Gc usage data #1

Bernadetadad opened this issue Aug 18, 2024 · 2 comments

Comments

@Bernadetadad
Copy link

@jbloom would be good to also include Ne5Gc functional selection data in the phenotype list. I think we want to show the increase in Neu5Gc usage and we have this data in the main flu repo here (it's not in the phenotypes summary file as we're not using it in the any publication yet).

@jbloom
Copy link
Member

jbloom commented Aug 19, 2024

@Bernadetadad, I'm happy to do this, but can you process the data you want plotted better first?

For instance, for SA26 we just took values with positive differences (better on SA26) and overall improved entry on SA26 cells. The repo for the H5 DMS makes a file with these increase SA26 usage values.

In contrast, the file you linked to just has the raw differences taken over all values, not just then ones causing both relative and absolute improvements.

Also, what filters should be applied to times_seen and diffference_std?

In general, this should be sorted out in the H5 DMS analysis repo. So for instance, if you only want the increases, make a rule like process_SA26_improvement in custom_rules.smk to generate that file. Alternatively, if you just want the raw differences let me know.

@jbloom
Copy link
Member

jbloom commented Aug 25, 2024

@Bernadetadad, no rush if it's not a current priority, but just re-upping above issue that I need more clarity on what data you want plotted as mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants