We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If we want to support music videos, we need at least a basic support of BPM (beats per minute)
this will help us product a nice grid alignment
If you search for BPM in the code base, you will see there are already function to detect that.
Note that to work as expected, we will need to make the duration per step variable.
Initially we were using this:
import { DEFAULT_DURATION_IN_MS_PER_STEP } from "@/constants"
But I've just pushed a PR to move this to durationInMsPerStep inside the useTimeline
durationInMsPerStep
useTimeline
this is still static, but at least now we have a way to mutate the value of durationInMsPerStep based on the detected BPM
The text was updated successfully, but these errors were encountered:
partially done, I've added:
However, the BPM isn't fully connected to the timeline grid yet (changing it won't change the alignment of segments yet)
and yes, later we can have BPM per-segment (with segments acting as groups)
Sorry, something went wrong.
jbilcke-hf
No branches or pull requests
Context
If we want to support music videos, we need at least a basic support of BPM (beats per minute)
this will help us product a nice grid alignment
Solution
Notes
If you search for BPM in the code base, you will see there are already function to detect that.
Note that to work as expected, we will need to make the duration per step variable.
Initially we were using this:
But I've just pushed a PR to move this to
durationInMsPerStep
inside theuseTimeline
this is still static, but at least now we have a way to mutate the value of
durationInMsPerStep
based on the detected BPMThe text was updated successfully, but these errors were encountered: