Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onRowHovered event callback #807

Closed
wants to merge 4 commits into from
Closed

Add onRowHovered event callback #807

wants to merge 4 commits into from

Conversation

TreyBastian
Copy link

@TreyBastian TreyBastian commented May 18, 2021

This PR just adds a callback to allow actions to be taken when a row is hovered.

Our use-case was to prefetch data that that is normally requested when a user clicks on a row.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #807 (1629065) into next (bff4eee) will decrease coverage by 72.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             next     #807       +/-   ##
===========================================
- Coverage   98.21%   25.94%   -72.28%     
===========================================
  Files          42       42               
  Lines         897      902        +5     
  Branches      328      330        +2     
===========================================
- Hits          881      234      -647     
- Misses          7      664      +657     
+ Partials        9        4        -5     
Impacted Files Coverage Δ
src/DataTable/DataTable.tsx 0.00% <0.00%> (-97.61%) ⬇️
src/DataTable/TableRow.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/DataTable/defaultProps.tsx 100.00% <ø> (ø)
src/DataTable/Cell.ts 0.00% <0.00%> (-100.00%) ⬇️
src/DataTable/Table.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/DataTable/TableCol.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/DataTable/TableBody.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/DataTable/TableCell.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/DataTable/TableHead.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/icons/NativeSortIcon.tsx 0.00% <0.00%> (-100.00%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff4eee...1629065. Read the comment docs.

@TreyBastian
Copy link
Author

any updates on weather or not this PR is going to be accepted?

I'd definitely prefer to not really need to vendor this dependency.

@jbetancur
Copy link
Owner

@TreyBastian thank you for the PR and I think this is a feature that is needed. Sorry, I've not had the time to review. I'll try to look sometime today.

@jbetancur jbetancur self-assigned this Jun 9, 2021
@jbetancur jbetancur modified the milestone: RDT Next Jun 9, 2021
src/DataTable/types.ts Outdated Show resolved Hide resolved
@jbetancur
Copy link
Owner

Looks good! Just a few comments to address and also this will need an entry in the README documentation for the new property

@TreyBastian
Copy link
Author

Looks good! Just a few comments to address and also this will need an entry in the README documentation for the new property

Sounds great -- I'll get the documentation in later tonight. Thanks for having a look!

@jbetancur
Copy link
Owner

@TreyBastian looks like there's a busted test/lint that I fixed as part of a refactor in #818. Please rebase these changes into your branch before pushing any changes up. Thanks!

@TreyBastian
Copy link
Author

Hey, been a bit busy not been able to sort this out. I'll get this fixed this week. Would definitely like to get it in!

@guyllkegen
Copy link

Hey, been a bit busy not been able to sort this out. I'll get this fixed this week. Would definitely like to get it in!

Any update on this feature?

@guyllkegen
Copy link

@TreyBastian have you been able to look at this PR

@jbetancur
Copy link
Owner

jbetancur commented Sep 24, 2021

This PR has gone stale or has ben unresponsive so closing. We can look to adding this as a future feature request.

@jbetancur jbetancur closed this Sep 24, 2021
@DjovDev
Copy link

DjovDev commented Jan 20, 2022

Do I undestand correct that this has not been implemented yet? We actually could really use the onRowHover functionality in one of our projects and we're kinda jammed. Any chance on reopening this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants