-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onRowHovered event callback #807
Conversation
Codecov Report
@@ Coverage Diff @@
## next #807 +/- ##
===========================================
- Coverage 98.21% 25.94% -72.28%
===========================================
Files 42 42
Lines 897 902 +5
Branches 328 330 +2
===========================================
- Hits 881 234 -647
- Misses 7 664 +657
+ Partials 9 4 -5
Continue to review full report at Codecov.
|
any updates on weather or not this PR is going to be accepted? I'd definitely prefer to not really need to vendor this dependency. |
@TreyBastian thank you for the PR and I think this is a feature that is needed. Sorry, I've not had the time to review. I'll try to look sometime today. |
Looks good! Just a few comments to address and also this will need an entry in the README documentation for the new property |
Sounds great -- I'll get the documentation in later tonight. Thanks for having a look! |
@TreyBastian looks like there's a busted test/lint that I fixed as part of a refactor in #818. Please rebase these changes into your branch before pushing any changes up. Thanks! |
Hey, been a bit busy not been able to sort this out. I'll get this fixed this week. Would definitely like to get it in! |
Any update on this feature? |
@TreyBastian have you been able to look at this PR |
This PR has gone stale or has ben unresponsive so closing. We can look to adding this as a future feature request. |
Do I undestand correct that this has not been implemented yet? We actually could really use the onRowHover functionality in one of our projects and we're kinda jammed. Any chance on reopening this? |
This PR just adds a callback to allow actions to be taken when a row is hovered.
Our use-case was to prefetch data that that is normally requested when a user clicks on a row.