Skip to content

Commit 6dbe9da

Browse files
author
Jason Bedard
committed
add additional ng_module in ng_package wrapping @angular/cdk/overlay injectable
1 parent 979660f commit 6dbe9da

File tree

6 files changed

+39
-0
lines changed

6 files changed

+39
-0
lines changed

ui/BUILD

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ load("@angular//packages/bazel:index.bzl", "ng_module", "ng_package")
77

88
UI_COMPONENTS = [
99
"banner",
10+
"injected",
1011
]
1112

1213
UI_COMPONENT_PACKAGES = ["//ui/%s" % p for p in UI_COMPONENTS]
@@ -27,5 +28,8 @@ ng_package(
2728
globals = {
2829
'@angular/material/button': 'ng.material.button',
2930
'@angular/material/icon': 'ng.material.icon',
31+
32+
'@angular/cdk/overlay': 'ng.cdk.overlay',
33+
'@angular/cdk/scrolling': 'ng.cdk.scrolling', #<-- indirect dep of @angular/cdk/overlay, containing ngfactory which is missing
3034
}
3135
)

ui/injected/BUILD

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
package(default_visibility = ["//visibility:public"])
2+
3+
load("@angular//packages/bazel:index.bzl", "ng_module")
4+
5+
ng_module(
6+
name = "injected",
7+
srcs = glob(["*.ts"]),
8+
module_name = "@npmscope/ui/injected",
9+
deps = [
10+
"@npm//@types",
11+
"@angular//packages/core",
12+
"@angular_material//src/cdk/overlay",
13+
],
14+
)

ui/injected/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './public_api';

ui/injected/module.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import {OverlayModule} from '@angular/cdk/overlay';
2+
import {NgModule} from '@angular/core';
3+
4+
import {Overlayer} from './overlayer';
5+
6+
@NgModule({
7+
imports: [OverlayModule],
8+
9+
providers: [Overlayer]
10+
})
11+
export class BannerWrapperModule {}

ui/injected/overlayer.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import {Injectable} from '@angular/core';
2+
import {Overlay} from '@angular/cdk/overlay';
3+
4+
@Injectable({providedIn: 'root'})
5+
export class Overlayer {
6+
constructor(private overlay: Overlay) {}
7+
}

ui/injected/public_api.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export * from './module';
2+
export * from './overlayer';

0 commit comments

Comments
 (0)