Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for custom intercept logic. #59

Merged
merged 1 commit into from
Apr 8, 2015

Conversation

kkaehler
Copy link
Contributor

@kkaehler kkaehler commented Apr 7, 2015

I really want to integrate silk into our dev/staging environments but we need more fine-grained controls over when it is enabled. Let me know if you've been thinking of a better way to do this.

mtford90 added a commit that referenced this pull request Apr 8, 2015
Add configuration option for custom intercept logic.
@mtford90 mtford90 merged commit 4dfc053 into jazzband:master Apr 8, 2015
@mtford90
Copy link
Collaborator

mtford90 commented Apr 8, 2015

I think this is a great way of doing that, slots in nicely with everything else. Cheers!

@kkaehler
Copy link
Contributor Author

Unfortunately I screwed up the implementation of this.

Since I did this by passing a reference to the function this gets set when settings are imported and before django has added the application name to the path. What this means is that you get import errors if you want to import any application specific code for this method.

I have a fix in which you pass a string referencing the file instead of the function itself (this is what the debug-toolbar does). Would you prefer for me to remove the pass by reference option or leave both?

@mtford90
Copy link
Collaborator

@kkaehler woops :).

Yeah prob best to remove the pass by ref and make sure this is all documented rather than leave something in that could leave people confused ;)

appreciate the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants